Revert "Don't appbundle from within bundle exec" #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the problems with this are very annoying:
Things like travis will set BUNDLE_GEMFILE but the user may not
bundle install
orbundle exec
so we can't rely on that as a test to see if we're in bundler.We rely on
eval "$(/opt/chefdk/bin/chef shell-init bash)"
to clean up the rvm environment in travis.The workflow that we would have to support is:
eval "$(/opt/chefdk/bin/chef shell-init bash)"
and reset the env vars <-- this relies on the binstubs to reset the env to even invoke thechef
command./opt/chefdk/embedded/bin/chef --version
should workNote that what people do is call embedded directly, that's not a typo there, so it bypasses the binstubs and just uses chefdk as a normal ruby.