Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't appbundle from within bundle exec" #42

Merged
merged 1 commit into from May 11, 2018

Conversation

lamont-granquist
Copy link
Contributor

@lamont-granquist lamont-granquist commented May 11, 2018

So the problems with this are very annoying:

  1. Things like travis will set BUNDLE_GEMFILE but the user may not bundle install or bundle exec so we can't rely on that as a test to see if we're in bundler.

  2. We rely on eval "$(/opt/chefdk/bin/chef shell-init bash)" to clean up the rvm environment in travis.

  • GEM_PATH + GEM_HOME are set by rvm and must be cleaned in order to run the shell-init command
  • after shell-init is run GEM_PATH + GEM_HOME are set pointing at chefdk + the .chefdk dir

The workflow that we would have to support is:

  • use rvm and create an empty gemset
  • eval "$(/opt/chefdk/bin/chef shell-init bash)" and reset the env vars <-- this relies on the binstubs to reset the env to even invoke the chef command.
  • /opt/chefdk/embedded/bin/chef --version should work

Note that what people do is call embedded directly, that's not a typo there, so it bypasses the binstubs and just uses chefdk as a normal ruby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant