[automate-1755] Reset checked projects list upon opening create… #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were actually two pieces of state to adjust. 1. Uncheck all the projects in the dropdown upon opening the modal for creating teams and tokens. 2. Update the label on the closed dropdown that reflects the state of that list. Signed-off-by: michael sorens <msorens@chef.io>
Signed-off-by: michael sorens <msorens@chef.io>
msorens
added
bug 🐛
msorens
commented
Oct 11, 2019
| @@ -48,7 +48,8 @@ <h2 slot="title">Create {{ objectNoun | titlecase }}</h2> | |||
| <app-projects-dropdown | |||
| [projects]="projects" | |||
| (onProjectChecked)="onProjectChecked($event)" | |||
| [disabled]="dropdownDisabled()"> | |||
| [disabled]="dropdownDisabled()" | |||
| [projectsUpdated]="projectsUpdatedEvent"> | |||
There was a problem hiding this comment.
Conduit to let the dropdown know to update the closed dropdown label.
Comment on lines
-46
to
+48
| // if a new list of projects to populate dropdown with is passed in we update the dropdown | ||
| const checked = false; | ||
| if (hasIn('assignableProjects.currentValue', changes)) { | ||
| // update project dropdown if list changes | ||
| if (changes.assignableProjects) { | ||
| this.projects = {}; | ||
| changes.assignableProjects.currentValue.forEach((proj: Project) => | ||
| this.projects[proj.id] = { ...proj, checked }); | ||
| this.projects[proj.id] = { ...proj, checked: false }); |
There was a problem hiding this comment.
PR extras: there are a variety of small cleanups such as the above in this PR unrelated to the issue being fixed.
Comment on lines
+50
to
+53
| // clear checked projects when opening | ||
| if (changes.visible && (changes.visible.currentValue as boolean)) { | ||
| Object.values(this.projects).forEach(p => p.checked = false); | ||
| this.projectsUpdatedEvent.emit(); |
There was a problem hiding this comment.
This is half of the fix: resetting all the projects to unchecked upon opening the modal.
Comment on lines
-22
to
+23
| (keydown.enter)="closeColumnDropdown()" | ||
| (keydown.esc)="closeColumnDropdown()" | ||
| (keydown.enter)="closeDropdown()" | ||
| (keydown.esc)="closeDropdown()" |
There was a problem hiding this comment.
PR extra: bug fix! This function had been renamed some time ago but these were missed.
Comment on lines
+44
to
+49
| ngOnInit(): void { | ||
| if (this.projectsUpdated) { // an optional setting | ||
| this.projectsUpdated.subscribe(() => { | ||
| this.updateLabel(); | ||
| }); | ||
| } |
There was a problem hiding this comment.
This is the other half of the fix: resyncing the label to the now all-unchecked list of projects.
| @@ -8,7 +8,7 @@ export const projectsFilterState = state => state.projectsFilter; | |||
| export const options = createSelector(projectsFilterState, state => state.options); | |||
|
|
|||
| export const assignableProjects = createSelector(projectsFilterState, state => { | |||
| let projectOptions = state.options.filter((p: ProjectsFilterOption) => p.checked); | |||
| let projectOptions = (state.options as ProjectsFilterOption[]).filter(p => p.checked); | |||
There was a problem hiding this comment.
Introduce strong type at the start so everything else in this block is now typed, too.
susanev
approved these changes
Oct 11, 2019
msorens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
The
CreateObjectModalComponent(used for creating tokens and teams at present) appeared to retain the last set of selected projects. However, that was a phantom. They were not really selected. So upon saving the new token/team, it would show in the tokens/teams list with just(unassigned), leaving the user confused.Two separate things to fix:
Resetting all projects on the dropdown to unchecked.
Updating the dropdown label when it is closed to reflect that no projects are checked.
⛓️ Related Resources
NA
👍 Definition of Done
Opening the "create team" (or "create token") modal for the second time in succession shows an unchecked projects list.
👟 How to Build and Test the Change
rebuild automate-ui
Create one or more projects (Settings >> Projects >> Create Project)
Create a team (Settings >> Teams >> Create Team), selecting one or more projects (1).
Save that team.
Select "Create Team" a second time (2).
Observe the projects dropdown labels should say
(unassigned)and the projects dropdown list of projects should show all unchecked.📷 Screenshots, if applicable