Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps tab: Correctly support 64bit IDs in all the code #3718

Merged
merged 1 commit into from
May 18, 2020

Conversation

danielsdeleo
Copy link
Contributor

馃敥 Description: What code changed, and why?

In #3560 we fixed ingestion of services when the sequence generator for IDs had exceeded the max size of a 32 bit integer. There is some code used to generate the dashboard that's still expecting 32 bit integers for the IDs, it needs to be updated for 64 bit.

Signed-off-by: Daniel DeLeo <dan@chef.io>
@danielsdeleo danielsdeleo requested a review from a team as a code owner May 18, 2020 17:32
@danielsdeleo danielsdeleo merged commit c6b0678 into master May 18, 2020
@danielsdeleo danielsdeleo deleted the dan/apps-bigint-again branch May 18, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants