Jamie/3982 data lifecycle additions #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 30, 2020 11:15
Signed-off-by: seajamied <jdegnan@chef.io>
Signed-off-by: seajamied <jdegnan@chef.io>
Signed-off-by: seajamied <jdegnan@chef.io>
Signed-off-by: seajamied <jdegnan@chef.io>
Signed-off-by: seajamied <jdegnan@chef.io>
Signed-off-by: seajamied <jdegnan@chef.io>
SEAjamieD
added
documentation
susanev
approved these changes
Jun 30, 2020
Signed-off-by: seajamied <jdegnan@chef.io>
updated - thank you! |
|
oh i need to add the docs commit, ill do that tonight |
Signed-off-by: susanev <susan.ra.evans@gmail.com>
danielsdeleo
approved these changes
Jul 1, 2020
kagarmoe
approved these changes
Jul 1, 2020
msorens
reviewed
Jul 2, 2020
| // Service Groups are not currently uncheckable through the UI | ||
| .filter( form => !['serviceGroupNoHealthChecks', 'serviceGroupRemoveServices'] | ||
| .includes(form)), | ||
| using(ALL_FORMS.map( form => form ), |
There was a problem hiding this comment.
What are you trying to achieve with this no-op map call?
I suspect the filter(identity) pattern might be more appropriate.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
This is an update to data-lifecycle that now allows a user to make changes to Service Groups through the UI.
⛓️ Related Resources
API work: #3931
👍 Definition of Done
A user is now able to successfully change and retain Service groups updates through the UI
👟 How to Build and Test the Change
build components/automate-ui-devproxy && start_all_services
make serve
navigate to https://a2-dev.test/settings/data-lifecycle
The Service Groups section should no longer be disabled.
Check/UnCheck the Service groups and click the submit button. You should see a success ribbon.
Change the Values in the Service groups section and submit. Check for success ribbon.
Refresh the page - you should see the same values that were previously submitted in the service groups section.
All other sections on the page should retain the same functionality.
✅ Checklist
📷 Screenshots, if applicable
Before:
After:
