Jamie/aus utc bug #4030
Merged
Jamie/aus utc bug #4030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SEAjamieD
added
ui
automate-ui
HIGH PRIORITY
msorens
reviewed
Jul 2, 2020
components/automate-ui/src/app/pages/+compliance/+reporting/reporting.component.spec.ts
Outdated
Show resolved
Hide resolved
|
@susanev - This branch still needs updated tests - but I'm ok with testing it in the wild as long as we can get tests done before its actually released. |
added 7 commits
July 8, 2020 13:34
Signed-off-by: seajamied <jdegnan@chef.io>
Signed-off-by: seajamied <jdegnan@chef.io>
Signed-off-by: seajamied <jdegnan@chef.io>
Signed-off-by: seajamied <jdegnan@chef.io>
Signed-off-by: seajamied <jdegnan@chef.io>
Signed-off-by: seajamied <jdegnan@chef.io>
susanev
approved these changes
Jul 8, 2020
… and until it can be figured out, its holding up testing in acceptance. This is currently alwasy returning todays date in the test only Signed-off-by: seajamied <jdegnan@chef.io>
SEAjamieD
force-pushed
the
jamie/aus-utc-bug
branch
from
17695f9
to
68b39f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
The date picker on compliance reports page is displaying the previous date to customers in Australia time zone (and possibly others). We would like the date picker to always display in UTC.
⛓️ Related Resources
Addresses: #4015
Need to be careful that this does not undo all of work in #1624
👍 Definition of Done
The Date picker is always displaying UTC time.
👟 How to Build and Test the Change
build components/automate-ui-devproxy && start_all_services
make serve
navigate to https://a2-dev.test/compliance/reports/overview
By default, the date should match up with the current UTC Date
Select a date in the future
Repeat this flow several times for several different dates.
Change your timezone to locations in Japan, Australia, US, Europe, Russia, etc.
Repeat steps from above in each location.
** to change your timezone in chrome dev tools click on the three dot menu in devtools > more tools > sensors
✅ Checklist
📷 Screenshots, if applicable