Send an event to the notifications-service when there are no failed r… #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 7, 2020 11:44
…esources in a failed client run Signed-off-by: Martin Scott <mscott@chef.io>
Signed-off-by: Martin Scott <mscott@chef.io>
satellite15
added
customer-reported
lancewf
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…esources in a failed client run
Signed-off-by: Martin Scott mscott@chef.io
See #4039
🔩 Description: What code changed, and why?
Send an event to the notifications-service for a failed client run that does not have a failed resource.
⛓️ Related Resources
👍 Definition of Done
👟 How to Build and Test the Change
Build and deploy the automate-gateway
Set up a notification for slack, webhook and servicenow (can be same destination as webhook).
Perform a client run for a cookbook that does not compile. This is fairly easy to do, just type some random words into a cookbook and it will not compile.
Verify notifications are received.
✅ Checklist
📷 Screenshots, if applicable