Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill out remaining dashboard desktop detail info #4058

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

scottopherson
Copy link
Contributor

馃敥 Description: What code changed, and why?

This commit replaces the remaining hardcoded data in the dashboard desktop detail view with real data fetched from the cfgmgmt API.

鉀擄笍 Related Resources

#3639

馃憤 Definition of Done

There is no longer any hardcoded data in the dashboard desktop detail view.

馃憻 How to Build and Test the Change

  • Start all services and UI
  • Have some data to look at in the dashboard:
# From hab studio
for _ in {1..50}; do m=$((RANDOM % 4)); n=$((RANDOM % 4)); generate_chef_run_failure_example | jq --arg msg "Error $n occurred" --arg type "Chef::ExampleError$m" '.error.message = $msg | .error.class = $type' | send_chef_data_raw; done
  • Navigate to a2-dev.test/desktop and select any item on the dashboard to bring up the desktop list view
  • Select a desktop from the desktop list to bring up the desktop detail view

@scottopherson
Copy link
Contributor Author

Occasionally, a node will be returned with some missing data attributes (usually if the node has a lot of failed/missing runs), but timezone seems to always return undefined 馃

Copy link
Contributor

@tarablack01 tarablack01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Awesome! 馃帀

This commit replaces the remaining hardcoded data in the dashboard desktop detail view with real data fetched from the cfgmgmt API.

Signed-off-by: Scott Christopherson <scott@chef.io>
Copy link

@vjeffrey vjeffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@mjingle mjingle mentioned this pull request Jul 13, 2020
4 tasks
@scottopherson scottopherson merged commit 24868b1 into master Jul 13, 2020
@chef-expeditor chef-expeditor bot deleted the sc/desktop-detail branch July 13, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants