Removes option to add teams for new project #4149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakestier
force-pushed
the
3980/remove-broken-add-teams-functionality
branch
3 times, most recently
from
12797cd
to
84547f4
Compare
blakestier
added
auth-team
msorens
approved these changes
Jul 29, 2020
| 'editors': 'Editors', | ||
| 'viewers': 'Viewers' | ||
| }; | ||
|
|
||
| constructor( | ||
| private layoutFacade: LayoutFacadeService, | ||
| private store: Store<NgrxStateAtom>, |
There was a problem hiding this comment.
Just below here you need to delete this line:
addTeams: [true]
84547f4
to
6c68345
Compare
because teams is a separate service that is dependent on auth, tying these created teams to policies in the most readable, maintainable way requires significant effort, so we are removing the option for now. Signed-off-by: Blake Johnson <bstier@chef.io>
blakestier
force-pushed
the
3980/remove-broken-add-teams-functionality
branch
from
6c68345
to
7d96410
Compare
srenatus
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敥 Description: What code changed, and why?
Because teams is a separate service that is dependent on auth,
tying these created teams to policies in the most readable,
maintainable way requires significant effort (using cereal or merging teams into authz), so we are
removing the option for now.
馃憻 How to Build and Test the Change
Enter the studio and bring up the UI-- Navigate to "Settings" in the UI, then "Projects". Click "Create Project":
-- there should not be an option to automatically create teams
-- when project is created, there should be no associated teams