-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chef patents link (Automate UI) #4283
Conversation
Deploy preview for chef-automate ready! Built with commit 2817a3c |
components/automate-ui/src/app/page-components/profile/profile.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment for improved security - all in all working great 馃憤
This commit adds a Chef patents link to the user profile dropdown menu. Signed-off-by: Scott Christopherson <scott@chef.io>
5a42da9
to
2817a3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -45,7 +45,7 @@ | |||
#focusElement>About</button> | |||
</li> | |||
<li> | |||
<a href="https://www.chef.io/online-master-agreement/" target="_blank" | |||
<a href="https://www.chef.io/online-master-agreement/" target="_blank" rel="noopener" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃帀 Nice to bring in noopener
for added security--I was not aware of that at all.
Here's a link for posterity explaining it: https://pointjupiter.com/what-noopener-noreferrer-nofollow-explained/
馃敥 Description: What code changed, and why?
This commit adds a Chef patents link to the user profile dropdown menu.
鉀擄笍 Related Resources
Closes: #4220
Aha! Link: https://chef.aha.io/features/SH-231