Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chef patents link (Automate UI) #4283

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Add Chef patents link (Automate UI) #4283

merged 1 commit into from
Sep 4, 2020

Conversation

scottopherson
Copy link
Contributor

@scottopherson scottopherson commented Aug 31, 2020

馃敥 Description: What code changed, and why?

This commit adds a Chef patents link to the user profile dropdown menu.

鉀擄笍 Related Resources

Closes: #4220

Aha! Link: https://chef.aha.io/features/SH-231

@netlify
Copy link

netlify bot commented Aug 31, 2020

Deploy preview for chef-automate ready!

Built with commit 2817a3c

https://deploy-preview-4283--chef-automate.netlify.app

Copy link
Contributor

@SEAjamieD SEAjamieD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment for improved security - all in all working great 馃憤

This commit adds a Chef patents link to the user profile dropdown menu.

Signed-off-by: Scott Christopherson <scott@chef.io>
Copy link
Contributor

@Shadae Shadae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤
giphy

@@ -45,7 +45,7 @@
#focusElement>About</button>
</li>
<li>
<a href="https://www.chef.io/online-master-agreement/" target="_blank"
<a href="https://www.chef.io/online-master-agreement/" target="_blank" rel="noopener"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀 Nice to bring in noopener for added security--I was not aware of that at all.
Here's a link for posterity explaining it: https://pointjupiter.com/what-noopener-noreferrer-nofollow-explained/

@vjeffrey vjeffrey merged commit e7b53e0 into master Sep 4, 2020
@vjeffrey vjeffrey deleted the sc/patents branch September 4, 2020 17:12
@vjeffrey vjeffrey added Epic and removed Epic labels Sep 28, 2020
@vjeffrey vjeffrey changed the title Add Chef patents link Add Chef patents link (Automate UI) Sep 28, 2020
@vjeffrey
Copy link

vjeffrey commented Nov 2, 2020

Comment added by Lisa Stidham in Aha! - View

Updating status to Ready for Delivery based on the merge indicated in #4283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Patents" link needs to be added to Automate
5 participants