Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display message when no tests were run #4352

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

SEAjamieD
Copy link
Contributor

πŸ”© Description: What code changed, and why?

This branch updates the Compliance Reports node detail view to show a message when no tests were run on that specific node.

⛓️ Related Resources

Addresses: #1761

πŸ‘ Definition of Done

A message is displayed when there are no results to show on the compliance report detail view

πŸ‘Ÿ How to Build and Test the Change

build components/automate-ui-devproxy
make serve

  1. Download profile that will have no test outcome: display message when control results are emptyΒ #1761 (comment)
  2. Upload profile into automate
  3. Navigate to https://a2-dev.test/compliance/compliance-profiles and upload the profile downloaded in step 1
  4. Navigate to https://a2-dev.test/compliance/scan-jobs/jobs and create a scan job with this profile
  5. Navigate to https://a2-dev.test/compliance/reports/nodes and find the node you scanned with the profile from step 1
  6. Open passed profile and see that it has no tests, with a message informing you similar to the image below.

βœ… Checklist

πŸ“· Screenshots, if applicable

After
No tests

Signed-off-by: seajamied <jdegnan@chef.io>
@netlify
Copy link

netlify bot commented Sep 17, 2020

Deploy preview for chef-automate ready!

Built with commit 1efeda8

https://deploy-preview-4352--chef-automate.netlify.app

@SEAjamieD SEAjamieD requested review from jonong1972 and a team September 17, 2020 21:06
@msorens
Copy link
Contributor

msorens commented Sep 18, 2020

I lack familiarity with the context here, but the explanatory text is ambiguous.

It could mean either:

  1. There were some tests but none were executed (for unknown reasons).
  2. There were no tests to run.

@SEAjamieD SEAjamieD self-assigned this Sep 18, 2020
@SEAjamieD SEAjamieD added automate-ui compliance reporting This issue or pull request applies to the compliance reporting part of Automate ui labels Sep 18, 2020
@vjeffrey
Copy link

@msorens we don't actually have a way of knowing whether it was situation 1 or 2

@SEAjamieD SEAjamieD requested a review from a team September 30, 2020 19:00
Copy link
Contributor

@scottopherson scottopherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@SEAjamieD SEAjamieD merged commit 027b648 into master Oct 1, 2020
@SEAjamieD SEAjamieD deleted the jamie/1761-empty-control-results branch October 1, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automate-ui compliance reporting This issue or pull request applies to the compliance reporting part of Automate ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants