Fix incorrect reporting-profile sidebar expansion content #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes #4333 The scan results expansion items were not being correctly mapped to the nodes they belong to. Signed-off-by: Scott Christopherson <scott@chef.io>
|
Deploy preview for chef-automate ready! Built with commit 2b58c5a |
vjeffrey
approved these changes
Sep 21, 2020
msorens
reviewed
Sep 22, 2020
| @@ -1,6 +1,10 @@ | |||
| import { Injectable } from '@angular/core'; | |||
| import { BehaviorSubject, Observable } from 'rxjs'; | |||
|
|
|||
| interface ControlsByNode { | |||
| [nodeId: string]: any; | |||
There was a problem hiding this comment.
So the controls do not have any definite type? I do see a lot of any values here and below. 🤷
There was a problem hiding this comment.
Yes, this entire area of the code really needs more types.
susanev
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
This commit fixes #4333
The scan results expansion items were not being correctly mapped to the nodes they belong to.