Add UTC label in the date picker #4448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for chef-automate ready! Built with commit b10b135 |
Signed-off-by: Alex Pop <apop@chef.io>
alexpop
force-pushed
the
ap/utc-on-comp-date-picker
branch
from
d79afd6
to
e89ef4b
Compare
|
@alexpop yeah, Thats pretty much what I was thinking. just adding that (UTC) to the date after selected. |
|
Actually one thing. Camel Case the "PICK DATE" Maybe "Choose Date" |
Signed-off-by: Alex Pop <apop@chef.io>
|
Thank you Jon for the review, I pushed another commit to replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敥 Description: What code changed, and why?
After merging #4358 some users might get confused between local time selections (
Last 24 hours) and the places where we select/show a day which is UTC.As can be seen in the below git that Scott uploaded in the UI pull request:
In the same dropdown the user can choose between
Last 24 hoursin the local timezone to a DAY, without any hint that this day is not in their timezone, but in UTC.In an effort to make this UTC aspect more clear, I'm submitting this PR with two changes as can be seen in the screenshots below:
During date selection:
After day selection from date picker: