Modify nginx_jdomain repo #4769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for chef-automate ready! Built with commit 146eb94 |
kalroy
commented
Feb 25, 2021
| @@ -1,7 +1,7 @@ | |||
| daemon off; | |||
| pid {{ pkg.svc_var_path }}/pid; | |||
| worker_processes {{ cfg.ngx.main.worker_processes }}; | |||
| error_log {{ cfg.ngx.main.error_log }} {{ cfg.logger.level }}; | |||
| error_log {{ cfg.ngx.main.error_log }} {{ cfg.log.level }}; | |||
There was a problem hiding this comment.
This is not related to the PR but found a bug with the config related to nginx log path
kalroy
commented
Feb 25, 2021
| jdomain_filename="ngx_upstream_jdomain-${jdomain_version}.tar.gz" | ||
| jdomain_source="https://github.com/nicholaschiasson/ngx_upstream_jdomain/archive/${jdomain_version}.tar.gz" | ||
| jdomain_shasum=e7346dac41d473ea02995b7626bd0660115538c2c784dfe683e235c58dbc2c2c | ||
| jdomain_version="master" |
There was a problem hiding this comment.
I didn't find any tag/version associated in the Repo to refer so going along with master.
Signed-off-by: Kallol Roy <karoy@progress.com>
Signed-off-by: Kallol Roy <karoy@progress.com>
kalroy
force-pushed
the
kallol/es-gateway-nginx-jdomain-fix
branch
from
a5f3b15
to
146eb94
Compare
vivek-yadav
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kallol Roy karoy@progress.com
🔩 Description: What code changed, and why?
nginx_upstream_jdomain was introduced in
20201230192246release to handle dynamic resolution of the hostnames based on the local/etc/resolv.conf.This helps in resolving and connecting to nodes in ES cluster managed by cloud providers where change of IP address because of change of a parameter in a cluster is expected.
A very common such use case is with AWS ES.
Although the change worked for such a cluster with master nodes but it failed to resolve IP in case of clusters with no master nodes and only data nodes.
This results in Automate Compliance/Infrastructure pages returning no data or unresponsive.
This is because the nginx jdomain module added has a bug which stops it from resolving the IP address in a regular interval.
This change considers the wdaike nginx jdomain module which was originally written.
⛓️ Related Resources
4751
👍 Definition of Done
The change in the ES cluster which can trigger a blue/green deployment and assigning of new IP addresses to the data nodes should not cause Automate to stop fetching ES data from the cluster.
👟 How to Build and Test the Change
✅ Checklist
📷 Screenshots, if applicable