Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra Views Read/Write] Delete Infra Role UI #4792

Merged
merged 11 commits into from
Mar 5, 2021

Conversation

vinay033
Copy link
Collaborator

@vinay033 vinay033 commented Mar 3, 2021

πŸ”© Description: What code changed, and why?

We need to add the UI for the Infra Role delete (Using new UI )

Chef Automate

⛓️ Related Resources

#3777

πŸ‘ Definition of Done

I have added a new UI delete modal popup and some other changes to delete the Infra Role.

πŸ‘Ÿ How to Build and Test the Change

Go to the `infrastructure tab` from the top navigation bar then you can see the `Chef Server`
If you have data then you can see the list of servers --> click  to any server ---> you can see the list of orgs --> 
click to any org ---> you can see the multiple tabs after clicking on org (cookbooks, roles, environments, databags, clients)

click to the roles tab and you can see the list of roles --> for a single object on the right side you can see the three dots (...).
you can click on that and see the delete link. if you click on that delete modal will be open.

βœ… Checklist

πŸ“· Screenshots, if applicable

delete-role.mp4

@netlify
Copy link

netlify bot commented Mar 3, 2021

Deploy preview for chef-automate processing.

Building with commit 4617f74

https://app.netlify.com/sites/chef-automate/deploys/6041e01fd5d6f10007de0ccc

Copy link
Collaborator

@vivekshankar1 vivekshankar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vinay033 . Looks good to me and works as expected.

Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: vinay sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
@kalroy kalroy self-requested a review March 5, 2021 09:30
Copy link
Collaborator

@kalroy kalroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI looks good.

@kalroy kalroy merged commit 9b42920 into master Mar 5, 2021
@kalroy kalroy deleted the Vinay/delete_infra_role_UI branch March 5, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants