-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added UI for edit environment. #4844
Conversation
Deploy preview for chef-automate processing. Building with commit 788b25f https://app.netlify.com/sites/chef-automate/deploys/605a1e746fb85b0008a11ff3 |
280390c
to
9569e91
Compare
9569e91
to
172f54a
Compare
filter(({ payload }: UpdateEnvironmentFailure) => payload.status !== HttpStatus.CONFLICT), | ||
map(({ payload }: UpdateEnvironmentFailure) => new CreateNotification({ | ||
type: Type.error, | ||
message: `Could not Update notification: ${payload.error.error || payload}.` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this error message, relace with the environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes looks good to me, need to update the error message for update failure.
172f54a
to
986bd6c
Compare
Signed-off-by: Himanshi Chhabra <himanshi.chhabra@msystechnologies.com>
Signed-off-by: Himanshi Chhabra <himanshi.chhabra@msystechnologies.com>
Signed-off-by: Himanshi Chhabra <himanshi.chhabra@msystechnologies.com>
Signed-off-by: Himanshi Chhabra <himanshi.chhabra@msystechnologies.com>
Signed-off-by: Himanshi Chhabra <himanshi.chhabra@msystechnologies.com>
Signed-off-by: Himanshi Chhabra <himanshi.chhabra@msystechnologies.com>
Signed-off-by: Himanshi Chhabra <himanshi.chhabra@msystechnologies.com>
986bd6c
to
788b25f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled the branch locally and tested out the feature, it working as expected. Thanks!
While acceptance testing, observed
|
π© Description: What code changed, and why?
We need to add UI for EDIT Environment
βοΈ Related Resources
#4545
π Definition of Done
Added edit functionality for Environment in which we can edit:
π How to Build and Test the Change
To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
Steps:
β Checklist
π· Screenshots, if applicable