Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra proxy edit mode - added some UI improvements #4888

Merged
merged 4 commits into from
Apr 6, 2021

Conversation

vinay033
Copy link
Collaborator

@vinay033 vinay033 commented Mar 30, 2021

Signed-off-by: Vinay Sharma vsharma@chef.io

πŸ”© Description: What code changed, and why?

we need to fix the below-mentioned points

  • In the Environment list/ Databag list/ client list page height of the search icon is overlapping the search bar border.
  • CSS of create and edit pop-up of Databag as it overrides all other pop-ups CSS.
  • Search buttons are not keyboard accessible.
  • In Create Environment, disable create button if a name already exists.
  • In create Environment, change the border color of the text-field when focused.
  • Edit databag item -> open item details -> cursor is always pointer

⛓️ Related Resources

#4873

πŸ‘ Definition of Done

I have added some changes for the UI improvements.

πŸ‘Ÿ How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

navigate to `https://a2-dev.test/infrastructure/client-runs`
add some sample data and then test the changes using tab change

To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views

Go to the `infrastructure tab` from the top navigation bar then you can see the `Chef Server`
If you have data then you can see the list of servers --> then click to any of the server --> see the list of orgs 
--> click to any of org ---> you can see the multiple tabs --> you can test the individual points mentioned in the description.

βœ… Checklist

πŸ“· Screenshots, if applicable

@netlify
Copy link

netlify bot commented Mar 30, 2021

Deploy preview for chef-automate processing.

Building with commit 9b844d4

https://app.netlify.com/sites/chef-automate/deploys/606bcd800e4e490007a6da8a

Copy link
Contributor

@himanshi-chhabra himanshi-chhabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vinay033 vinay033 requested a review from SEAjamieD March 30, 2021 15:29
@@ -36,7 +36,7 @@ <h2 slot="title">Create Environment</h2>
</div>
<div class="button-bar-box">
<chef-button tertiary (click)="closeCreateModal()">Cancel</chef-button>
<chef-button [disabled]="!detailsFormGroup?.valid || conflictError" primary id="create-button-object-modal" (click)="createEnvironment()">
<chef-button [disabled]="!detailsFormGroup?.valid || conflictError || nameExist" primary id="create-button-object-modal" (click)="createEnvironment()">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent - thank you for checking against existing names

Copy link
Contributor

@SEAjamieD SEAjamieD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @vinay033!

Many changes have been made to the styling of similar files in #4875. Please have a look at this PR and lets plan to merge #4875 before this one.

Change Request
In the Create Environment Modal, when a user adds a "space" in front of the desired name, it is seen as a new name. This should be trimmed in some fashion when checking for same name.

To reproduce
Navigate to an organization > environments > click "Create Environment"
Make a new environment with any name (ex. "mytest")
Make a second new environment using same name plus a space (ex. " mytest")
The warning goes away and you are allowed to create. Thankfully, the backend does not let a user create this name, but we should handle it on the front end as well.

@vinay033 vinay033 force-pushed the Vinay/UI_improvement_changes branch 2 times, most recently from eaa44a0 to 9464c51 Compare April 1, 2021 09:02
Copy link
Contributor

@SEAjamieD SEAjamieD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Vinay! πŸŽ‰

@SEAjamieD SEAjamieD force-pushed the Vinay/UI_improvement_changes branch from 9464c51 to ea6ebd7 Compare April 6, 2021 00:10
@SEAjamieD
Copy link
Contributor

@vinay033 I rebased and corrected the merge conflicts and will merge as soon as tests pass πŸ‘

@kalroy kalroy mentioned this pull request Apr 6, 2021
13 tasks
vinay033 and others added 4 commits April 5, 2021 19:54
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: seajamied <jdegnan@chef.io>
@SEAjamieD SEAjamieD force-pushed the Vinay/UI_improvement_changes branch from ea6ebd7 to 9b844d4 Compare April 6, 2021 02:54
@SEAjamieD SEAjamieD merged commit 4e7c58a into master Apr 6, 2021
@SEAjamieD SEAjamieD deleted the Vinay/UI_improvement_changes branch April 6, 2021 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants