Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed loading still active & not showing the message if admin key is invalid. #4946

Merged
merged 2 commits into from Apr 18, 2021

Conversation

vinay033
Copy link
Collaborator

@vinay033 vinay033 commented Apr 12, 2021

Signed-off-by: Vinay Sharma vsharma@chef.io

🔩 Description: What code changed, and why?

Any error while loading roles, environments, data bags, etc. loading still active. For cookbooks, it's working fine.
In case of any type of error response, it's always showing the message on the page.

⛓️ Related Resources

#4825

👍 Definition of Done

I have added some changes to fix this issue.

👟 How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

navigate to `https://a2-dev.test/infrastructure/chef-servers`
add some sample data and then test the changes using tab change
Go to the `infrastructure tab` from the top navigation bar then you can see the `Chef Server`
you need to add the server first ---> click to this server, then you need to add the org with an invalid admin key.
Note: Add an invalid admin key at the time of adding  the org
 
--> click to org ---> you can see the multiple tabs --> cookbooks, roles, environments, databags, clients 
if you click on any of the tabs then you can see the message.

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Chef Automate (17)
Chef Automate (18)

@netlify
Copy link

netlify bot commented Apr 12, 2021

Deploy preview for chef-automate processing.

Building with commit 5c6175b

https://app.netlify.com/sites/chef-automate/deploys/607c7f66736ccf0007a4b037

Copy link
Collaborator

@vivekshankar1 vivekshankar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vinay033 , Its working as expected

@vinay033 vinay033 changed the title Fixed loading still active & clicking on reset admin key page get blank Fixed loading still active & not showing the message if admin key is invalid. Apr 14, 2021
@vinay033 vinay033 force-pushed the Vinay/reset_admin_key_issue_fix branch from 1366bd8 to c6de655 Compare April 16, 2021 06:48
Copy link
Contributor

@chaitali-mane chaitali-mane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vinay033 , Looks good to me

@vinay033 vinay033 force-pushed the Vinay/reset_admin_key_issue_fix branch from c6de655 to 2115b59 Compare April 16, 2021 15:25
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
@kalroy kalroy force-pushed the Vinay/reset_admin_key_issue_fix branch from 2115b59 to 5c6175b Compare April 18, 2021 18:50
@kalroy kalroy merged commit 22508e4 into master Apr 18, 2021
@kalroy kalroy deleted the Vinay/reset_admin_key_issue_fix branch April 18, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants