-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added edit mode UI improvements #4954
Conversation
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Deploy preview for chef-automate ready! Built with commit a2ac78c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @chaitali-mane , looks good to me
Signed-off-by: chaitali-mane <cmane@progress.com>
@chaitali-mane all other CSS changes are fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ππ»
π© Description: What code changed, and why?
Found some improvements in testing so some of them covered in this PR.
βοΈ Related Resources
4873
π Definition of Done
I have changes databags to "Data bags" in infra views and also updated CSS of tabs in details page.
π How to Build and Test the Change
STEP 1
inside the hab studio
[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services
STEP 2
open new window
go to automate UI path
$ cd components/automate-ui
and run the command
npm run serve:hab
navigate to
https://a2-dev.test/infrastructure/chef-servers
Go to the
infrastructure tab
from the top navigation bar then you can see theChef Infra Server
-> Chef OrganizationWhere you can check the changes
β Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
π· Screenshots, if applicable