Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added edit mode UI improvements #4954

Merged
merged 5 commits into from
Apr 20, 2021
Merged

Conversation

chaitali-mane
Copy link
Contributor

@chaitali-mane chaitali-mane commented Apr 15, 2021

πŸ”© Description: What code changed, and why?

Found some improvements in testing so some of them covered in this PR.

  1. In Environment/ Databag/ Client/ Role details page update the CSS of tabs.
  2. While creating the first Databag item I do not see the data bag item immediately.
  3. Databag should be referred as "Data Bag" in the UI

⛓️ Related Resources

4873

  1. In Environment/ Databag/ Client/ Role details page update the CSS of tabs.
  2. While creating the first Databag item I do not see the data bag item immediately.
  3. Databag should be referred as "Data Bag" in the UI

πŸ‘ Definition of Done

I have changes databags to "Data bags" in infra views and also updated CSS of tabs in details page.

πŸ‘Ÿ How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command

npm run serve:hab

navigate to https://a2-dev.test/infrastructure/chef-servers
Go to the infrastructure tab from the top navigation bar then you can see the Chef Infra Server -> Chef Organization
Where you can check the changes

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

image

vinay033 and others added 3 commits April 15, 2021 12:23
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
@netlify
Copy link

netlify bot commented Apr 15, 2021

Deploy preview for chef-automate ready!

Built with commit a2ac78c

https://deploy-preview-4954--chef-automate.netlify.app

Copy link
Collaborator

@vivekshankar1 vivekshankar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @chaitali-mane , looks good to me

chaitali-mane and others added 2 commits April 19, 2021 10:37
@vinay033
Copy link
Collaborator

@chaitali-mane
regarding
While creating the first Databag item I do not see the data bag item immediately.
I did not see any changes for this.

all other CSS changes are fine.

@vinay033 vinay033 self-requested a review April 20, 2021 08:01
Copy link
Collaborator

@vinay033 vinay033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘πŸ»

@kalroy kalroy merged commit a8f680b into master Apr 20, 2021
@kalroy kalroy deleted the Vinay/Edit_mode_ui_improvements branch April 20, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants