-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added delete button on node list page #5042
Conversation
Deploy preview for chef-automate processing. Building with commit 71064fa https://app.netlify.com/sites/chef-automate/deploys/609a27d0108a1800075e585c |
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
a4cfce6
to
c0eaaf8
Compare
Signed-off-by: chaitali-mane <cmane@progress.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great job on this @chaitali-mane π
<app-delete-infra-object-modal | ||
[visible]="deleteModalVisible" | ||
objectNoun="node" | ||
[objectName]="nodeToDelete?.name" | ||
(close)="closeDeleteModal()" | ||
(deleteClicked)="deleteNode()" | ||
objectAction="Delete"> | ||
</app-delete-infra-object-modal> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the extra space above this line:
Signed-off-by: chaitali-mane <cmane@progress.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Chaitali Mane cmane@progress.com
π© Description: What code changed, and why?
βοΈ Related Resources
4999
4918
π Definition of Done
I have added changes for the delete modal and node list page for delete.
π How to Build and Test the Change
STEP 1
inside the hab studio
[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services
STEP 2
open new window
go to automate UI path
$ cd components/automate-ui
and run the command
npm run serve:hab
navigate to
https://a2-dev.test/infrastructure/client-runs
add some sample data and then test the changes using tab change
To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
Go to the
infrastructure tab
from the top navigation bar then you can see theChef Server
If you have data then you can see the list of servers --> then click to any of server --> see the list of orgs
--> click to any of org ---> you can see the multiple tabs
a) Click to any tab from Roles, Environment, Data Bags, Clients
--> check last column of one node
--> you can see the delete button, when you click a modal will be open and you can delete the node.
--> Where you can see changes
b) click to
Nodes
tab--> see the list of nodes
--> check last column of one node
--> you can see the delete button, when you click a modal will be open and you can delete the node.
β Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
π· Screenshots, if applicable
Changed text in delete modal
![delete-client](https://user-images.githubusercontent.com/71449322/117452701-b4816700-af61-11eb-9e41-9436ec4a5623.png)
Delete Node
Delete.Node.mp4