Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added delete button on node list page #5042

Merged
merged 6 commits into from
May 11, 2021
Merged

Conversation

chaitali-mane
Copy link
Contributor

@chaitali-mane chaitali-mane commented May 6, 2021

Signed-off-by: Chaitali Mane cmane@progress.com

πŸ”© Description: What code changed, and why?

  • Need to change text in delete Modal.
  • Need to add delete node list UI.

⛓️ Related Resources

4999
4918

πŸ‘ Definition of Done

I have added changes for the delete modal and node list page for delete.

πŸ‘Ÿ How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command

npm run serve:hab

navigate to https://a2-dev.test/infrastructure/client-runs
add some sample data and then test the changes using tab change

To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views

Go to the infrastructure tab from the top navigation bar then you can see the Chef Server
If you have data then you can see the list of servers --> then click to any of server --> see the list of orgs
--> click to any of org ---> you can see the multiple tabs
a) Click to any tab from Roles, Environment, Data Bags, Clients
--> check last column of one node
--> you can see the delete button, when you click a modal will be open and you can delete the node.
--> Where you can see changes
b) click to Nodes tab
--> see the list of nodes
--> check last column of one node
--> you can see the delete button, when you click a modal will be open and you can delete the node.

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

  1. Changed text in delete modal
    delete-client

  2. Delete Node

Delete.Node.mp4

@chaitali-mane chaitali-mane self-assigned this May 6, 2021
@netlify
Copy link

netlify bot commented May 6, 2021

Deploy preview for chef-automate processing.

Building with commit 71064fa

https://app.netlify.com/sites/chef-automate/deploys/609a27d0108a1800075e585c

Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
@chaitali-mane chaitali-mane marked this pull request as ready for review May 7, 2021 13:26
Copy link
Contributor

@SEAjamieD SEAjamieD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great job on this @chaitali-mane πŸŽ‰

Comment on lines 3 to 10
<app-delete-infra-object-modal
[visible]="deleteModalVisible"
objectNoun="node"
[objectName]="nodeToDelete?.name"
(close)="closeDeleteModal()"
(deleteClicked)="deleteNode()"
objectAction="Delete">
</app-delete-infra-object-modal>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the extra space above this line:

Signed-off-by: chaitali-mane <cmane@progress.com>
Copy link
Contributor

@himanshi-chhabra himanshi-chhabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalroy kalroy merged commit 66eeefb into master May 11, 2021
@kalroy kalroy deleted the Chaitali/infra_delete_node branch May 11, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants