Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra node reset client key #5088

Merged
merged 5 commits into from
May 27, 2021
Merged

Infra node reset client key #5088

merged 5 commits into from
May 27, 2021

Conversation

vinay033
Copy link
Collaborator

@vinay033 vinay033 commented May 21, 2021

Signed-off-by: Vinay Sharma vsharma@chef.io

πŸ”© Description: What code changed, and why?

we need to allow users to reset the Key for a Node.

⛓️ Related Resources

#4917

πŸ‘ Definition of Done

I have covered the below mentioned points

  • I have added the feature to reset the node key
  • I have added the cypress specs for this feature

πŸ‘Ÿ How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

navigate to `https://a2-dev.test/infrastructure/chef-servers`
add some sample data and then test the changes using tab change

To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views

Go to the -->  `infrastructure tab` from the top navigation bar then you can see the `Chef Infra Server`
If you have data then you can see the list of servers 
--> then click to any of the servers --> see the list of org's
--> click to any of org ---> you can see the multiple tabs --> default tab is cookbooks tab 
--> you can see the nodes tab ---> click to nodes tab
--> if nodes are available then you can see the list of nodes with search and pagination.
--> you can see the `...` three-dot on the right side for each node when you click you can see the reset key option.

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

reset-node-key.mp4

@netlify
Copy link

netlify bot commented May 21, 2021

πŸ‘· Deploy Preview for chef-automate processing.

πŸ”¨ Explore the source changes: 3c71286

πŸ” Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60ae15308c5cbf0008aa87d9

Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
@sonarcloud
Copy link

sonarcloud bot commented May 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@SEAjamieD SEAjamieD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @vinay033! πŸŽ‰

Copy link
Contributor

@himanshi-chhabra himanshi-chhabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good Thanks @vinay033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants