Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Infra Node attributes UI and cypress test cases. #5194

Merged
merged 13 commits into from
Jun 9, 2021

Conversation

chaitali-mane
Copy link
Contributor

@chaitali-mane chaitali-mane commented Jun 4, 2021

Signed-off-by: Chaitali Mane cmane@progress.com

🔩 Description: What code changed, and why?

  • Add Edit/Update node attributes UI to update the node run list.
  • Add cypress test case for the attributes, edit the attributes and change tab.
  • Add Edit/Update node attributes UI on node list dropdown page.

⛓️ Related Resources

#4921

👍 Definition of Done

  • Added UI for attributes tab.
  • Added UI for edit attributes.
  • Added dropdown for edit attributes on node list page.
  • Added cypress test cases.

👟 How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

To add data
https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views

Steps for attributes tab:

  1. Go To Infrastructure -> Chef Servers -> click server name-> click on org name -> Nodes.
  2. Click on particular node -> attributes tab -> will show list of attributes if particular node has it -> Edit button -> to edit the attributes and update.

Steps node dropdown for edit attributes:
1.Go To Infrastructure -> Chef Servers -> click server name-> click on org name -> Nodes.
2. Click on particular node -> click Edit attributes -> to edit the attributes and update.

For cypress Build
https://github.com/chef/automate/tree/master/e2e

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

  1. UI for attributes tab
    node-attr-1

  2. UI for edit attributes
    node-attr-2

  3. dropdown for edit attributes
    node-attr-3

Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
@netlify
Copy link

netlify bot commented Jun 4, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 0a55a8e

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60be587740ac200007572e8c

Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
@chaitali-mane chaitali-mane marked this pull request as ready for review June 4, 2021 14:48
Signed-off-by: chaitali-mane <cmane@progress.com>
Copy link
Collaborator

@vinay033 vinay033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me.

Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@himanshi-chhabra himanshi-chhabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @chaitali-mane

@kalroy kalroy merged commit 20e21b3 into master Jun 9, 2021
@kalroy kalroy deleted the Chaitali/infra_node_attributes branch June 9, 2021 02:17
@chaitali-mane
Copy link
Contributor Author

Found issue while acceptance testing. Created below issue #5255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants