-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Infra Node attributes UI and cypress test cases. #5194
Conversation
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
👷 Deploy Preview for chef-automate processing. 🔨 Explore the source changes: 0a55a8e 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60be587740ac200007572e8c |
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
...s/infra-proxy/edit-infra-node-attribute-modal/edit-infra-node-attribute-modal.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good to me.
...les/infra-proxy/edit-infra-node-attribute-modal/edit-infra-node-attribute-modal.component.ts
Outdated
Show resolved
Hide resolved
...automate-ui/src/app/modules/infra-proxy/infra-node-details/infra-node-details.component.html
Outdated
Show resolved
Hide resolved
...automate-ui/src/app/modules/infra-proxy/infra-node-details/infra-node-details.component.html
Outdated
Show resolved
Hide resolved
...automate-ui/src/app/modules/infra-proxy/infra-node-details/infra-node-details.component.html
Outdated
Show resolved
Hide resolved
...automate-ui/src/app/modules/infra-proxy/infra-node-details/infra-node-details.component.html
Show resolved
Hide resolved
...automate-ui/src/app/modules/infra-proxy/infra-node-details/infra-node-details.component.html
Outdated
Show resolved
Hide resolved
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @chaitali-mane
Found issue while acceptance testing. Created below issue #5255 |
Signed-off-by: Chaitali Mane cmane@progress.com
🔩 Description: What code changed, and why?
⛓️ Related Resources
#4921
👍 Definition of Done
👟 How to Build and Test the Change
To add data
https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
Steps for attributes tab:
Steps node dropdown for edit attributes:
1.Go To Infrastructure -> Chef Servers -> click server name-> click on org name -> Nodes.
2. Click on particular node -> click Edit attributes -> to edit the attributes and update.
For cypress Build
https://github.com/chef/automate/tree/master/e2e
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
UI for attributes tab
![node-attr-1](https://user-images.githubusercontent.com/71449322/120816732-a75e9480-c56e-11eb-9289-9960774b45cd.png)
UI for edit attributes
![node-attr-2](https://user-images.githubusercontent.com/71449322/120816735-a9285800-c56e-11eb-8885-3132652ad12e.png)
dropdown for edit attributes
![node-attr-3](https://user-images.githubusercontent.com/71449322/120816740-a9c0ee80-c56e-11eb-9f8e-ca9dcfd02bb9.png)