Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pagination in Compliance reports #5360

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Conversation

chaitali-mane
Copy link
Contributor

@chaitali-mane chaitali-mane commented Jul 15, 2021

Signed-off-by: Chaitali Mane cmane@progress.com

πŸ”© Description: What code changed, and why?

Pagination is not updating when user apply any filter.

⛓️ Related Resources

#5322

πŸ‘ Definition of Done

Added code for updating pagination when filter applied in reports on nodes and profiles.

πŸ‘Ÿ How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

Steps for Policyfiles tab:
Go To Compliance -> click Reports -> click Nodes/ Profiles -> click on any filter

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

@netlify
Copy link

netlify bot commented Jul 15, 2021

πŸ‘· Deploy Preview for chef-automate processing.

πŸ”¨ Explore the source changes: 70f4090

πŸ” Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60fa9c8d96a1570007feac48

@chaitali-mane chaitali-mane self-assigned this Jul 15, 2021
@chaitali-mane chaitali-mane marked this pull request as ready for review July 16, 2021 06:29
Copy link
Contributor

@Venkatesh-rengasamy Venkatesh-rengasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2021

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit b8d3300 into master Jul 23, 2021
@kalroy kalroy deleted the Chaitali/compliance_reports branch July 23, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants