Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abdul/UI timeout fix #5362

Merged
merged 16 commits into from
Aug 17, 2021
Merged

Abdul/UI timeout fix #5362

merged 16 commits into from
Aug 17, 2021

Conversation

iamazzeez
Copy link
Contributor

Things Introduced.

  • Automate UI checks for user activities such as mouse movement, click, keyboard key press, scroll etc.
  • If there is no activity from user's side for the time specified for idle_timeout_minutes in config.toml then user will be explicitly logged out.
  • This feature can be enabled/disabled by enable_idle_timeout this property in config.toml
  • User kept multiple tabs/windows open but active on any one of the tab/window, to accommodate this use-case, such that
    user is not logged out as user is active. (https://github.com/pubkey/broadcast-channel) is used, It supports all browsers.

馃憻 How to Build and Test the Change

  • Pull changes from branch abdul/ui_timeout
  • update session.toml to desired values.

68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3630373439663132666431643334336639393666336164632f32303038383638322d303536342d343032302d623838632d623432336232303461383165

cd /src
rebuild components/automate-load-balance
rebuild components/automate-ui
rebuild components/automate-deployment
rebuild components/automate-cli

  • chef-automate config patch dev/session.toml

@iamazzeez iamazzeez requested a review from kalroy July 16, 2021 11:22
@iamazzeez iamazzeez self-assigned this Jul 16, 2021
@netlify
Copy link

netlify bot commented Jul 16, 2021 •
edited
Loading

馃懛 Deploy Preview for chef-automate processing.

馃敤 Explore the source changes: 05b373b

馃攳 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/611676746ffeb10007c19430

@kalroy kalroy requested a review from vinay033 July 23, 2021 14:39
@timdsmith72
Copy link

For the love of all that is holy, please get this resolved. I get logged out every 1 to 2 minutes. Sometimes, while I'm scrolling down the page.

@kalroy kalroy mentioned this pull request Aug 2, 2021
Closed
2 tasks
kalroy
kalroy approved these changes Aug 10, 2021
View reviewed changes
Copy link
Collaborator

@kalroy kalroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kalroy and others added 15 commits August 11, 2021 16:20
@kalroy @iamazzeez
Changes to make the banner as part of custom settings
713ba2f 
Signed-off-by: Kallol Roy <karoy@progress.com>
@kalroy @iamazzeez
Adding Custom Settings config in load balancer
db05935 
Signed-off-by: Kallol Roy <karoy@progress.com>
@kalroy @iamazzeez
Renamed the proto field names to be more meaningful
ecd0966 
Signed-off-by: Kallol Roy <karoy@progress.com>
@iamazzeez
u_timeout fix
e0d1169 
Signed-off-by: Abdul-Az <iamazzeez@gmail.com>
@kalroy @iamazzeez
Added global config
7981d5d 
Signed-off-by: Kallol Roy <karoy@progress.com>
@iamazzeez
added session.toml file
0e40220 
Signed-off-by: Abdul-Az <aazeez@progress.com>
@kalroy @iamazzeez
Fixing Config Patch
7f607cc 
Signed-off-by: Kallol Roy <karoy@progress.com>
@iamazzeez
multi tab fix
1e53163 
Signed-off-by: Abdul-Az <aazeez@progress.com>
@iamazzeez
fixed infinite loop
d832694 
Signed-off-by: Abdul-Az <aazeez@progress.com>
@iamazzeez
multi tabs logic update
52fd33c 
Signed-off-by: Abdul-Az <aazeez@progress.com>
@iamazzeez
increased logout time with 1min
a1349a6 
Signed-off-by: Abdul-Az <aazeez@progress.com>
@vinay033 @iamazzeez
minor changes to fix the lint issue
fede795 
Signed-off-by: Vinay Sharma <vsharma@chef.io>
@kalroy @iamazzeez
Adding proto into ignore list
4e8e807 
Signed-off-by: Kallol Roy <karoy@progress.com>
@kalroy @iamazzeez
Adding proto into ignore list
bc8f856 
Signed-off-by: Kallol Roy <karoy@progress.com>
@kalroy @iamazzeez
go fmt the files
ce0833d 
Signed-off-by: Kallol Roy <karoy@progress.com>
@iamazzeez
UserPreferencesRequests, added
05b373b 
Signed-off-by: Abdul-Az <aazeez@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2021

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@kalroy kalroy merged commit 7011913 into master Aug 17, 2021
@kalroy kalroy deleted the abdul/ui_timeout_fix branch August 17, 2021 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalroy kalroy kalroy approved these changes

@vinay033 vinay033 vinay033 approved these changes

Assignees

@iamazzeez iamazzeez

Labels
acceptance: verified automate-ui ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iamazzeez @timdsmith72 @kalroy @vinay033