Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEF Automate SAML - Blank Screen #5368

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Conversation

Venkatesh-rengasamy
Copy link
Contributor

@Venkatesh-rengasamy Venkatesh-rengasamy commented Jul 20, 2021

Signed-off-by: Venkatesh-rengasamy vrengasa@progress.com

πŸ”© Description: What code changed, and why?

Showing blank screen after login into saml.

⛓️ Related Resources

https://github.com/chef/customer-bugs/issues/438
#5366

πŸ‘ Definition of Done

Added hash key in content-security-policy in Response header.

πŸ‘Ÿ How to Build and Test the Change

Goto saml signin page --> click the signin button --> see the saml's login form. If login form shown and able to login to see the dashboard page then it is working as expected.

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
@netlify
Copy link

netlify bot commented Jul 20, 2021

πŸ‘· Deploy Preview for chef-automate processing.

πŸ”¨ Explore the source changes: 82aa310

πŸ” Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60f6cfd1f39ad00007d6e9a5

Copy link
Collaborator

@vinay033 vinay033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me.

Signed-off-by: Kallol Roy <karoy@progress.com>
@kalroy kalroy marked this pull request as ready for review July 20, 2021 13:30
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kalroy kalroy self-requested a review July 20, 2021 13:37
@kalroy kalroy merged commit 3c6ec81 into master Jul 20, 2021
@kalroy kalroy deleted the venkatesh/content_security_policy branch July 20, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants