Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Landing screen every time #5375

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Show Landing screen every time #5375

merged 2 commits into from
Jul 26, 2021

Conversation

kalroy
Copy link
Collaborator

@kalroy kalroy commented Jul 22, 2021

Signed-off-by: Kallol Roy karoy@progress.com

πŸ”© Description: What code changed, and why?

For a user who does not have SAML login setup, the landing page is not setup.
The user is shown the login page directly.
This change will make sure that every type of user is shown the landing page first

By landing page I mean this page:

image

⛓️ Related Resources

#5379

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

  • hab studio enter
  • rebuild components\automate-dex
  • remove the saml portion of the config in dev/config.toml
  • start_all_services
  • The landing page should be shown when you go to https://a2-dev.test
  • Open dev/patch.toml
  • make show = true for [global.v1.disclosure]
  • make show = true for [global.v1.banner]
  • chef-automate config patch dev/patch.toml
  • The disclosure message should be shown on the landing page
  • Test the changes in Chrome, Edge, Firefox

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

@netlify
Copy link

netlify bot commented Jul 22, 2021

βœ”οΈ Deploy Preview for chef-automate ready!

πŸ”¨ Explore the source changes: 39f387d

πŸ” Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60fb972966d71e000819c638

😎 Browse the preview: https://deploy-preview-5375--chef-automate.netlify.app/automate

kalroy and others added 2 commits July 24, 2021 09:59
Signed-off-by: Kallol Roy <karoy@progress.com>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
@kalroy kalroy marked this pull request as ready for review July 24, 2021 04:30
@kalroy kalroy self-assigned this Jul 24, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2021

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@himanshi-chhabra himanshi-chhabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸŽ‰

Copy link
Collaborator

@vinay033 vinay033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸŽ‰

@kalroy kalroy merged commit cab8cec into master Jul 26, 2021
@kalroy kalroy deleted the kallol/show_login_screen branch July 26, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants