Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added included policyfile details info. #5398

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

himanshi-chhabra
Copy link
Contributor

Signed-off-by: Himanshi Chhabra hchhabra@progress.com

🔩 Description: What code changed, and why?

  • Add included Policy file details page
  • Add revision button on included policy file slider

⛓️ Related Resources

#5246

👍 Definition of Done

  • Added included Policy file details page in slider and Go to policyfile details page button
  • Added revision button on included policy file slider
  • Added cypress test cases for the detail page.

👟 How to Build and Test the Change

PFA Video

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
Steps for policy file tab:

  1. Go To Infrastructure -> Chef Servers -> click server name-> click on org name -> policyfile tab.
  2. Will see the policy file if available else will see no preview.
  3. if available click on policy file name -> will see details page
  4. click on Included Policy file accordion -> List of included Policy -> click particular included policy file
  5. Opens a slider that contains if API is correct then :
    a) meta info of included policyfile
    b) Go to policyfile details page button -> click -> go to details page
    c) Revison list Button -> click opens new slider which contain list of revision id.
  6. Opens a slider that contains if API is not correct then :
    a) Customized notification
    b) No preview image.
    c) Disabled Go to policyfile details page button

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Video for POlicy file details Page:

included-policy-details.mp4

Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
@netlify
Copy link

netlify bot commented Jul 30, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 1745cba

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6103eaf61ea44e0007bcd11e

Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@himanshi-chhabra himanshi-chhabra requested review from Venkatesh-rengasamy and removed request for chaitali-mane July 30, 2021 13:05
Copy link
Contributor

@Venkatesh-rengasamy Venkatesh-rengasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kalroy kalroy merged commit cf74f62 into master Aug 3, 2021
@kalroy kalroy deleted the Himanshi/policyfile-metadata-info branch August 3, 2021 12:51
@himanshi-chhabra himanshi-chhabra added acceptance: verified Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues labels Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants