Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User setting for saml & ldap users #5432

Merged
merged 60 commits into from
Aug 18, 2021
Merged

Conversation

Venkatesh-rengasamy
Copy link
Contributor

@Venkatesh-rengasamy Venkatesh-rengasamy commented Aug 5, 2021

πŸ”© Description: What code changed, and why?

Add timeformat on saml & ldap account and hide the display name field & Reset password tab.

⛓️ Related Resources

#5393 #5392

πŸ‘ Definition of Done

Added timeformat dropdown in user detail page. Hided the Reset password tab, display name field.

πŸ‘Ÿ How to Build and Test the Change

You can see the Profile Icon at top right corner in header. Click the Profile Icon -> you can see the menu list -> click the profile menu -> you can see the user details page -> choose any time-format on drop-down and save the preference -> goto API token page and see the date & time values are formatted based on your preference.

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2021

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

this.store.dispatch(this.createUpdateNameUserAction(name));
if (this.userPrefsService.uiSettings &&
this.userPrefsService.uiSettings.isDisplayNameEditable) {
const name = this.displayNameForm.get('displayName').value.trim();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of const, you can define it as a public same as others.

Copy link
Collaborator

@vinay033 vinay033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘πŸ»

@kalroy kalroy merged commit 36766e6 into master Aug 18, 2021
@kalroy kalroy deleted the venkatesh/user_setting_saml_ldap branch August 18, 2021 15:46
@Venkatesh-rengasamy Venkatesh-rengasamy added acceptance: verified Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues labels Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: verified automate-ui Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Settings UI for LDAP users User Settings UI for SAML Users
4 participants