Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default setting for time format for user settings #5574

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

rickmarry
Copy link
Contributor

@rickmarry rickmarry commented Aug 24, 2021

Signed-off-by: Rick Marry rick.marry@gmail.com

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

from hab:
rebuild components/user-settings-service
chef-automate dev psql postgres
then from psql:
\c chef_user_settings_service
select * from user_settings;

default val should be:
"default_value": "ddd, DD MMM YYYY HH:mm:ss [UTC]",
value should be:
"value": "ddd, DD MMM YYYY HH:mm:ss [UTC]",

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Signed-off-by: Rick Marry <rick.marry@gmail.com>
@netlify
Copy link

netlify bot commented Aug 24, 2021

πŸ‘· Deploy Preview for chef-automate processing.

πŸ”¨ Explore the source changes: ddd15c3

πŸ” Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/61245fdb0d39d9000707333c

@rickmarry rickmarry requested a review from kalroy August 24, 2021 02:56
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2021

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@kalroy kalroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for local user and looks good

@kalroy kalroy merged commit d7fc22c into master Aug 24, 2021
@kalroy kalroy deleted the rm/change-default-on-time-format branch August 24, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants