jobs list and node read fixes #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 13, 2019 10:30
a scan job with a recurrence schedule should not show a report button on the jobs list. the report button should only show up on the actual scans list for recurring jobs.
if we cannot find the credential id attached to the node, we should not fail the node. we should just return what is found and leave it to the user from there. failing the node results in unreadable nodes, which helps no one. Signed-off-by: Victoria Jeffrey <vjeffrey@chef.io>
stevendanna
reviewed
Apr 15, 2019
Co-Authored-By: vjeffrey <vjeffrey@chef.io> Signed-off-by: Victoria Jeffrey <vjeffrey@chef.io>
scottopherson
approved these changes
Apr 15, 2019
afiune
pushed a commit
that referenced
this pull request
Apr 16, 2019
* only show report button on scan job list if not recurring job a scan job with a recurrence schedule should not show a report button on the jobs list. the report button should only show up on the actual scans list for recurring jobs. * do not fail node read if secret does not exist if we cannot find the credential id attached to the node, we should not fail the node. we should just return what is found and leave it to the user from there. failing the node results in unreadable nodes, which helps no one. Signed-off-by: Victoria Jeffrey <vjeffrey@chef.io> * Update components/nodemanager-service/api/nodes/server/server.go Co-Authored-By: vjeffrey <vjeffrey@chef.io> Signed-off-by: Victoria Jeffrey <vjeffrey@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敥 Description
only show report button on scan job list if not recurring job
a scan job with a recurrence schedule should not show a report
button on the jobs list. the report button should only show
up on the actual scans list for recurring jobs.
do not fail node read if secret does not exist
if we cannot find the credential id attached to the node,
we should not fail the node. we should just return what is
found and leave it to the user from there. failing the node
results in unreadable nodes, which helps no one.
馃憤 Definition of Done
bugs fixed
馃憻 Demo Script / Repro Steps
rebuild nodemanager-service
load up some nodes
create a recurring job that will complete soon
try to read a node
delete credential for node
try to read node again
check recurring job - should not have report button on jobs list, only on scans