Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra-proxy-service]Removed validation for description field while update role. #5648

Merged
merged 2 commits into from
Sep 3, 2021

Conversation

himanshi-chhabra
Copy link
Contributor

Signed-off-by: Himanshi Chhabra hchhabra@progress.com

🔩 Description: What code changed, and why?

Update Role even if the description field is blank.

⛓️ Related Resources

#5317

👍 Definition of Done

Updated Role even if the description field is blank.

👟 How to Build and Test the Change

Steps to build:

rebuild components/infra-proxy-service
rebuild components/automate-gateway

Steps to test:

  1. Ensure Chef Infra Server is running. If it is not start it with start_chef_server
  2. Create a role using knife create role test1
  3. Go to Roles tab -> click test1 role -> edit runlist or attribute and updating successfully if description is null.

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

description-val.mp4

@himanshi-chhabra himanshi-chhabra added automate-infra-proxy-api using for automate infra proxy backend api's Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues labels Sep 2, 2021
@himanshi-chhabra himanshi-chhabra self-assigned this Sep 2, 2021
@netlify
Copy link

netlify bot commented Sep 2, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 26462c4

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6130c23b79e80a0008fb58cd

@himanshi-chhabra himanshi-chhabra changed the title Removed validation for description field while update role. [infra-proxy-service]Removed validation for description field while update role. Sep 2, 2021
himanshi-chhabra and others added 2 commits September 2, 2021 17:48
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: root <swale@msystechnologies.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
100.0% 100.0% Duplication

Copy link
Contributor

@sonali523 sonali523 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected

@kalroy kalroy merged commit 9634a59 into main Sep 3, 2021
@kalroy kalroy deleted the Himanshi/role_validation branch September 3, 2021 08:18
vivek-yadav pushed a commit that referenced this pull request Sep 7, 2021
…pdate role. (#5648)

* removed validation for description field while update role.

Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>

* Updated validation with lint

Signed-off-by: root <swale@msystechnologies.com>

Co-authored-by: root <swale@msystechnologies.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: verified automate-infra-proxy-api using for automate infra proxy backend api's Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants