Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dropdown for fqdn and ip address. #5724

Merged
merged 6 commits into from
Sep 17, 2021
Merged

Conversation

himanshi-chhabra
Copy link
Contributor

@himanshi-chhabra himanshi-chhabra commented Sep 14, 2021

Signed-off-by: Himanshi Chhabra hchhabra@progress.com

🔩 Description: What code changed, and why?

We currently require both the FQDN and the IP address of the chef server. We need to change and make it optional so add a dropdown in which the user can select any option of FQDN or IP address

⛓️ Related Resources

#4945 #4998

👍 Definition of Done

Added a dropdown in which the user can select any option of FQDN or IP address

👟 How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
Steps for policy file tab:

  1. Go To Infrastructure -> Chef Servers -> click Add chef server -> Add name -> Select FQDN or IP Address option -> Add FQDN or IP Adress form filed data -> click Add chef server

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Chef-Automate (1)

Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
@himanshi-chhabra himanshi-chhabra added the Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues label Sep 14, 2021
@himanshi-chhabra himanshi-chhabra self-assigned this Sep 14, 2021
@netlify
Copy link

netlify bot commented Sep 14, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: abd52c4

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6144292579b7fe000822df6e

@chaitali-mane
Copy link
Contributor

Space between 'Type' and dropdown must be less.
space

@chaitali-mane
Copy link
Contributor

chaitali-mane commented Sep 15, 2021

If I select IP Adress and I cancel/ close modal and open again then the dropdown value is IP Adress. Same for the FQDN. Can dropdown be set to the default value?
Dropdown width is smaller compared to other

Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
@chaitali-mane
Copy link
Contributor

fqdn-err
I have some observations

  1. Font weight of dropdown must be normal.
  2. space between dropdown and below test should be more.
  3. height of dropdown should be the same

@chaitali-mane
Copy link
Contributor

If there is no data available for FQDN or IP Address then can we show '-' instead of empty?

Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Copy link
Contributor

@chaitali-mane chaitali-mane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected

@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 44b930f into main Sep 17, 2021
@kalroy kalroy deleted the Himanshi/create_server_dropdown branch September 17, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants