-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dropdown for fqdn and ip address. #5724
Conversation
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
👷 Deploy Preview for chef-automate processing. 🔨 Explore the source changes: abd52c4 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6144292579b7fe000822df6e |
If I select IP Adress and I cancel/ close modal and open again then the dropdown value is IP Adress. Same for the FQDN. Can dropdown be set to the default value? |
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
If there is no data available for FQDN or IP Address then can we show '-' instead of empty? |
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected
Kudos, SonarCloud Quality Gate passed!
|
Signed-off-by: Himanshi Chhabra hchhabra@progress.com
🔩 Description: What code changed, and why?
We currently require both the FQDN and the IP address of the chef server. We need to change and make it optional so add a dropdown in which the user can select any option of FQDN or IP address
⛓️ Related Resources
#4945 #4998
👍 Definition of Done
Added a dropdown in which the user can select any option of FQDN or IP address
👟 How to Build and Test the Change
To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
Steps for policy file tab:
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable