Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-Automate Manger gets linked to max 100 Node IDs#5631 #5761

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

shivangi-singh1
Copy link
Contributor

@shivangi-singh1 shivangi-singh1 commented Sep 20, 2021

🔩 Description: What code changed, and why?

  • Integration test case to test more than 100 nodes can be linked to Automate manager.

⛓️ Related Resources

Node manager service, default Automate Manger gets linked to max 100 Node IDs #5761

👍 Definition of Done

More than 100 nodes linked to automate manager.

👟 How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

make serve

To run cypress test
cd e2e
npm run cypress:local

Type feat to enable data-feed
Navigate to settings/data-feeds

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Sep 20, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: e778315

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6149fc471a5a0f00070dba62

Signed-off-by: Shivangi Singh <shisingh@progress.com>
Signed-off-by: Shivangi Singh <shisingh@progress.com>
Signed-off-by: Shivangi Singh <shisingh@progress.com>
Copy link
Collaborator

@vivekshankar1 vivekshankar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine, thanks

Signed-off-by: Shivangi Singh <shisingh@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vivek-yadav vivek-yadav merged commit caf711f into main Sep 27, 2021
@vivek-yadav vivek-yadav deleted the shivangi/Automate_manager5631 branch September 27, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: verified Team: S.H.I.E.L.D. This Label is used on S.H.I.E.L.D. Operations (Tasks / Stories)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node manager service, default Automate Manger gets linked to max 100 Node IDs
5 participants