Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ruby to 3.0 #5852

Merged
merged 1 commit into from Nov 16, 2021
Merged

Update Ruby to 3.0 #5852

merged 1 commit into from Nov 16, 2021

Conversation

damacus
Copy link
Contributor

@damacus damacus commented Oct 5, 2021 •
edited

🔩 Description: What code changed, and why?

Update Ruby & Ruby Gems

  • Upgrade to Ruby 3.0
  • Update bundle to the latest

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

📷 Screenshots, if applicable

@damacus
Update Ruby & Gems
4505dfb 
- Upgrade to Ruby 3.0
- Update bundle to the latest

Signed-off-by: Dan Webb <dan.webb@damacus.io>
@netlify
Copy link

netlify bot commented Oct 5, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 4505dfb

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/615c1e662054d30008f2d041

@vivek-yadav vivek-yadav merged commit e0ea146 into chef:main Nov 16, 2021
@vivek-yadav vivek-yadav mentioned this pull request Nov 16, 2021
Closed
9 tasks
@damacus damacus deleted the update/ruby3.0_and_gems branch November 16, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivek-yadav vivek-yadav vivek-yadav approved these changes

@vivekshankar1 vivekshankar1 vivekshankar1 approved these changes

@shivangi-singh1 shivangi-singh1 shivangi-singh1 approved these changes

@shaik80 shaik80 Awaiting requested review from shaik80

Assignees
No one assigned
Labels
acceptance: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating ruby version to ruby 3.0 Update Ruby to 2.7
5 participants
@damacus @vivek-yadav @vivekshankar1 @shivangi-singh1 @shaik80