-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go upgrade, Azure SDK upgrade with azure api scan filtering enabled #5870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing. 🔨 Explore the source changes: 95c6e1a 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6176f990e5870d00075fde77 |
d551af9
to
c1db68d
Compare
48917c4
to
35f0095
Compare
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
35f0095
to
40c6ffc
Compare
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Kudos, SonarCloud Quality Gate passed! |
shivangi-singh1
approved these changes
Oct 26, 2021
vivek-yadav
approved these changes
Oct 26, 2021
dkumaras
pushed a commit
that referenced
this pull request
Oct 26, 2021
…5870) * scaffolding version and golang version Signed-off-by: Vivek Shankar <vshankar@progress.com> * changes for azure sdk upgrade Signed-off-by: Vivek Shankar <vshankar@progress.com> * license scout crypto Signed-off-by: Vivek Shankar <vshankar@progress.com> * added filtering in backend api for api scan azure Signed-off-by: Vivek Shankar <vshankar@progress.com> * fixed duplicates Signed-off-by: Vivek Shankar <vshankar@progress.com> * revert changes on go.sum Signed-off-by: Vivek Shankar <vshankar@progress.com> * revert changes on go.sum Signed-off-by: Vivek Shankar <vshankar@progress.com> * fixed integration test cases for azure api Signed-off-by: Vivek Shankar <vshankar@progress.com> * add go sum Signed-off-by: Vivek Shankar <vshankar@progress.com> * certificate incompatibility issue fix for go 1.15 Signed-off-by: Vivek Shankar <vshankar@progress.com> * filter logic modified Signed-off-by: Vivek Shankar <vshankar@progress.com> * added fget fields Signed-off-by: Vivek Shankar <vshankar@progress.com> * removed logs and extra lines Signed-off-by: Vivek Shankar <vshankar@progress.com> * added unit and integration tests Signed-off-by: Vivek Shankar <vshankar@progress.com> * added unit and integration tests Signed-off-by: Vivek Shankar <vshankar@progress.com> * print subs Signed-off-by: Vivek Shankar <vshankar@progress.com> * check integration test Signed-off-by: Vivek Shankar <vshankar@progress.com> * added go debug env Signed-off-by: Vivek Shankar <vshankar@progress.com> * init method added for GODEBUG Signed-off-by: Vivek Shankar <vshankar@progress.com> * added tests of env Signed-off-by: Vivek Shankar <vshankar@progress.com> * set GODEBUG to PIPELINE Signed-off-by: Vivek Shankar <vshankar@progress.com> * more tests added Signed-off-by: Vivek Shankar <vshankar@progress.com> * refactored and timeout increase Signed-off-by: Vivek Shankar <vshankar@progress.com> * revereted vm changes Signed-off-by: Vivek Shankar <vshankar@progress.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
acceptance: verified
Team: S.H.I.E.L.D.
This Label is used on S.H.I.E.L.D. Operations (Tasks / Stories)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
In azure API scan we were not able to filter subscriptions. Lets say if any user has 1000 subscriptions and they want to run scans for some particular subscriptions it wasn't possible earlier. This change used the latest version of Azure SDK which helps us to gets the tags. We have added some filtering logic that can be used to choose particular subscriptions out of many. Scans will also use the chosen filters
To make this possible, we had to update Azure sdk, that relies on go 1.15 or more, so we had to update go version too. Pr also contains fix for common name support in certificate which requires env
GODEBUG=x509ignoreCN=0
to be set to support legacy certificates.Azure filtering and scanning supports wildcard matches too.
⛓️ Related Resources
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
Screen.Recording.2021-10-13.at.12.45.00.AM.mov