Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id as Primary Key from the orgs table #6017

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Conversation

kalroy
Copy link
Collaborator

@kalroy kalroy commented Oct 26, 2021

Signed-off-by: Kallol Roy karoy@progress.com

🔩 Description: What code changed, and why?

We need to remove the Primary Key constraint on org name from the org table.
This is to allow same orgs across different servers to be added.

⛓️ Related Resources

#5857

👍 Definition of Done

👟 How to Build and Test the Change

Prerequisites:
You need to have 2 infra servers Server1 and Server2. Both should have org with name Org1

  • rebuild components/infra-proxy-service/
  • start_all_services
  • Add Server1 to Infra Server
  • Add Org1 to Server1
  • Add Server2 to Infra Server
  • Add Org1 to Server2

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Kallol Roy <karoy@progress.com>
@netlify
Copy link

netlify bot commented Oct 26, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 9749c1d

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6177cea884cfaf00078c6534

@kalroy kalroy requested a review from vinay033 October 26, 2021 07:02
@kalroy kalroy self-assigned this Oct 26, 2021
Signed-off-by: Kallol Roy <karoy@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kalroy kalroy merged commit a39f43e into main Oct 26, 2021
@kalroy kalroy deleted the fix_infra_orgs_creation branch October 26, 2021 11:01
dkumaras pushed a commit that referenced this pull request Oct 26, 2021
* Remove id as Primary Key from the orgs table

Signed-off-by: Kallol Roy <karoy@progress.com>

* Committing readme file

Signed-off-by: Kallol Roy <karoy@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants