Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added paginator UI in Infra Roles tab (#5923) #6074

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

chaitali-mane
Copy link
Contributor

@chaitali-mane chaitali-mane commented Nov 9, 2021

Signed-off-by: chaitali-mane cmane@progress.com

🔩 Description: What code changed, and why?

Need to add new functionality of paginator with custom items per page dropdown in Infra tabs.
UX design -
https://www.figma.com/proto/bGLU1dghH8ZotUfI76OwwC/Manage->-Automate-Roles?page-id=0%3A1&node-id=1420%3A2673&viewport=241%2C48%2C0.08&scaling=min-zoom&starting-point-node-id=1420%3A2673

⛓️ Related Resources

#6072

👍 Definition of Done

Added custom dropdown paginator as per design.

👟 How to Build and Test the Change

inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

Steps for Infra tab:
Go To Infrastructure -> Chef Servers -> Click on any Chef Infra Server -> Click on any org -> Any tab (except cookbooks). where you can see changes

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

paginator

* Added UI for paginator

Signed-off-by: chaitali-mane <cmane@progress.com>

* Update for paginator

Signed-off-by: chaitali-mane <cmane@progress.com>

* Updated paginator code

Signed-off-by: chaitali-mane <cmane@progress.com>

* Updated code

Signed-off-by: chaitali-mane <cmane@progress.com>

* update options

Signed-off-by: chaitali-mane <cmane@progress.com>
@chaitali-mane chaitali-mane added automate-infra-proxy Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues labels Nov 9, 2021
@chaitali-mane chaitali-mane self-assigned this Nov 9, 2021
@netlify
Copy link

netlify bot commented Nov 9, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 9fb962d

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/618a97d7f5598f00079639fd

@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@Venkatesh-rengasamy Venkatesh-rengasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kalroy kalroy merged commit 2169e39 into main Nov 10, 2021
@kalroy kalroy deleted the Chaitali/infra_paginator branch November 10, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: verified automate-infra-proxy Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants