Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build forked dex in the plan file #6085

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Build forked dex in the plan file #6085

merged 1 commit into from
Nov 23, 2021

Conversation

kalroy
Copy link
Collaborator

@kalroy kalroy commented Nov 10, 2021

Signed-off-by: Kallol Roy karoy@progress.com

🔩 Description: What code changed, and why?

There is a need to validate the request id before we query the DB.
This requires us to make the changes in dex code base which is a third party code.
The process to make the change in the third party code and getting a merge approval can be troublesome and time consuming.
Hence the repo is forked and the changes are made in a branch on dex 2.27 version.
https://github.com/chef/dex-1/tree/add_request_validators

This PR is to make changes in the plan file to pull the code from the branch and build it.

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Nov 10, 2021

✔️ Deploy Preview for chef-automate ready!

🔨 Explore the source changes: 7dc3f36

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/619c6e42508a7e00086f8d92

😎 Browse the preview: https://deploy-preview-6085--chef-automate.netlify.app

@kalroy kalroy marked this pull request as draft November 10, 2021 15:56
@kalroy kalroy marked this pull request as ready for review November 15, 2021 06:54
Signed-off-by: Kallol Roy <karoy@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kalroy kalroy merged commit 8809440 into main Nov 23, 2021
@kalroy kalroy deleted the kallol/dex_db_pattern branch November 23, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants