Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix profle upload perm problem #6146

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

rickmarry
Copy link
Contributor

@rickmarry rickmarry commented Nov 16, 2021

πŸ”© Description: What code changed, and why?

This Pr fixes issue #5261 by setting permissions on the uzipped files so that we may edit them before converting them for upload

⛓️ Related Resources

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

rebuild components/compliance-service

go to the profiles tab in automate UI and upload a profile. The test profile to upload is located at:
<automate_root>/components/compliance-service/test_data/zipped_profiles/profile-1.0.0.zip

here is a screen cast that demonstrates the process:

fixed-profile-upload.mov

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

@netlify
Copy link

netlify bot commented Nov 16, 2021

πŸ‘· Deploy Preview for chef-automate processing.

πŸ”¨ Explore the source changes: 9e1ed46

πŸ” Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6197d51e7dbf59000807b1cc

@rickmarry rickmarry changed the title fix profle upload perm problem issue 5261 fix profle upload perm problem Nov 16, 2021
Rick Marry added 2 commits November 19, 2021 11:46
Signed-off-by: Rick Marry <rmarry@chef.io>
@rickmarry rickmarry force-pushed the rick/fix-profle-upload-perm-problem-issue-5261 branch from 79f81e3 to 9e1ed46 Compare November 19, 2021 16:47
@sonarcloud
Copy link

sonarcloud bot commented Nov 19, 2021

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@kalroy kalroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@kalroy kalroy merged commit 0c3a55b into main Dec 15, 2021
@kalroy kalroy deleted the rick/fix-profle-upload-perm-problem-issue-5261 branch December 15, 2021 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants