-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chaitali/test paginator #6196
Merged
Merged
Chaitali/test paginator #6196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing. 🔨 Explore the source changes: 6d2b8f9 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/61961012bc16160008ee897e |
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
chaitali-mane
force-pushed
the
Chaitali/test-paginator
branch
from
November 18, 2021 06:37
90ef344
to
1ae22da
Compare
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
vinay033
approved these changes
Nov 18, 2021
kalroy
approved these changes
Nov 18, 2021
chaitali-mane
added
acceptance: verified
automate-infra-proxy
Team: Stalwart
Migrate Chef Manage, UI bugs, UX improvements, CVE Issues
labels
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
acceptance: verified
automate-infra-proxy
Team: Stalwart
Migrate Chef Manage, UI bugs, UX improvements, CVE Issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chaitali-mane cmane@progress.com
🔩 Description: What code changed, and why?
Need to add new functionality of paginator with custom items per page dropdown in Infra tabs.
UX design -
https://www.figma.com/proto/bGLU1dghH8ZotUfI76OwwC/Manage->-Automate-Roles?page-id=0%3A1&node-id=1420%3A2673&viewport=241%2C48%2C0.08&scaling=min-zoom&starting-point-node-id=1420%3A2673
⛓️ Related Resources
#6072
👍 Definition of Done
Added custom dropdown paginator as per design.
👟 How to Build and Test the Change
Steps for Infra tab:
Go To Infrastructure -> Chef Servers -> Click on any Chef Infra Server -> Click on any org -> Any tab (except cookbooks). where you can see changes
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable