-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chef server ctl external database support #6643
Merged
vivek-yadav
merged 4 commits into
main
from
SHIELD-5/vshankar/chef-server-external-support
Feb 3, 2022
Merged
Chef server ctl external database support #6643
vivek-yadav
merged 4 commits into
main
from
SHIELD-5/vshankar/chef-server-external-support
Feb 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
👷 Deploy Preview for chef-automate processing. 🔨 Explore the source changes: afc0846 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/61f7d2e8eeff440008cf0ac2 |
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Kudos, SonarCloud Quality Gate passed! |
vivek-yadav
approved these changes
Feb 1, 2022
To solve this issue need to create admin user
|
shaik80
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
acceptance: verified
Team: S.H.I.E.L.D.
This Label is used on S.H.I.E.L.D. Operations (Tasks / Stories)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Earlier automate-cs-nginx had hardcoded erchef and bifrost db uri in its codebase. Now we are dynamically creating the connection string to support both external and embedded database. We have also given options to pass custom connection string and custom service path.
⛓️ Related Resources
#4285
👍 Definition of Done
All chef-server-ctl commands should work properly
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable