use dropdown for checkin history period #6702
Conversation
Signed-off-by: rishichawda <rishichawda@users.noreply.github.com>
|
✔️ Deploy Preview for chef-automate ready! 🔨 Explore the source changes: e8e7964 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/621378490945230007e8a2c6 😎 Browse the preview: https://deploy-preview-6702--chef-automate.netlify.app |
Signed-off-by: rishichawda <rishichawda@users.noreply.github.com>
Signed-off-by: rishichawda <rishichawda@users.noreply.github.com>
rishichawda
force-pushed
the
fix-dropdown-on-check-in-history
branch
from
e871b73
to
8baaa6f
Compare
| <chef-dropdown class='download' [visible]="downloadDropdownVisible"> | ||
| <div class="checkin-select"> | ||
| <chef-button secondary (click)="toggleCheckInPeriodDropdown()" class='download-dropdown-toggle'> | ||
| <span>Last {{ (checkInNumDays === twoWeekNumDays ? 2 : 4) }} Weeks</span> |
There was a problem hiding this comment.
we can shift this to the component.
(checkInNumDays === twoWeekNumDays ? 2 : 4)
There was a problem hiding this comment.
Yeah I thought so too at first when I looked at the code, but conditionally rendering the text here seems better than calling a function that wraps the same logic. So I let it be untouched.
Signed-off-by: rishichawda <rishichawda@users.noreply.github.com>
|
Updated the dropdown's hover and selected state colors based on input from ux team.
|
|
Kudos, SonarCloud Quality Gate passed!
|
Signed-off-by: rishichawda rishichawda@users.noreply.github.com
🔩 Description: What code changed, and why?
The Check-in history in node details on
/desktopdashboard has a toggle for switching between the periods which looks like a dropdown. Updated it to be a dropdown as intended. Along with that, there are a couple of minor changes to the same container to be semantically make more sense (main wrapper (the "heading component" is now a flex box, dropdown isn't fixed width, both drop downs are wrapped in their own space rather than just thrown in into the main container)⛓️ Related Resources
resolve #6207
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
The updated UI component