Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry coverage for InfraServer Roles Tab #6708

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

Venkatesh-rengasamy
Copy link
Contributor

@Venkatesh-rengasamy Venkatesh-rengasamy commented Feb 17, 2022

Signed-off-by: Venkatesh-rengasamy vrengasa@progress.com

🔩 Description: What code changed, and why?

Track the Infra-server roles actions using telemetry track event. The following actions should be tracked:- search, create, delete and edit roles.

⛓️ Related Resources

https://chefio.atlassian.net/browse/KINETICS-23

👍 Definition of Done

Infra-server roles actions are tracked using telemetry track event.

👟 How to Build and Test the Change

inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command

npm run serve:hab

Steps for preview screen:
Go To Infrastructure -> Chef Servers -> Click on any Chef Infra Server -> Click on Orgs name -> select Roles tab -> you can search, create, edit and delete roles -> For each actions, you can observe the telemetry track event in Network tab(inspect the element window).

API URL - https://telemetry-acceptance.chef.io/events

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
@netlify
Copy link

netlify bot commented Feb 17, 2022

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 4815935

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/620e7ff47bf2e9000789dd6b

Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Venkatesh-rengasamy
Copy link
Contributor Author

1
2
3
4
5
6

@Venkatesh-rengasamy Venkatesh-rengasamy self-assigned this Feb 17, 2022
@Venkatesh-rengasamy Venkatesh-rengasamy added Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues automate-ui telemetry automate-infra-proxy labels Feb 17, 2022
@Venkatesh-rengasamy Venkatesh-rengasamy marked this pull request as ready for review February 17, 2022 17:36
@kalroy kalroy self-requested a review February 21, 2022 15:38
@kalroy kalroy merged commit 2761d5a into main Feb 21, 2022
@kalroy kalroy deleted the venkatesh/KINETICS-23_telemetry_coverage_roles branch February 21, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automate-infra-proxy automate-ui Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants