Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On a freshly provisioned server, you get a notice saying that your license is about to expire. #6830

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

Venkatesh-rengasamy
Copy link
Contributor

@Venkatesh-rengasamy Venkatesh-rengasamy commented Mar 25, 2022

Signed-off-by: Venkatesh-rengasamy Venkatesh.Rengasamy@progress.com

🔩 Description: What code changed, and why?

On a freshly provisioned server, you get a notice saying that your license is about to expire. So we should remove the license-exp-notification message from showing on every time signin even if user's license are not expired.

⛓️ Related Resources

customer ticket - https://getchef.zendesk.com/agent/tickets/30268

👍 Definition of Done

Removed the license-exp-notification message

👟 How to Build and Test the Change

Log into chef-automate-ui,
You can see there is no notification message - ('License Update: your current license is expiring soon.' ) shown for fresh users.

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
@netlify
Copy link

netlify bot commented Mar 25, 2022

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 7155381
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/623d679cea97f400088a7311

@Venkatesh-rengasamy Venkatesh-rengasamy self-assigned this Mar 25, 2022
@Venkatesh-rengasamy Venkatesh-rengasamy added Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues automate-ui labels Mar 25, 2022
@Venkatesh-rengasamy Venkatesh-rengasamy marked this pull request as ready for review March 25, 2022 07:00
@sonarcloud
Copy link

sonarcloud bot commented Mar 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@vivekshankar1 vivekshankar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice not coming any more, LGTM

@vivek-yadav vivek-yadav merged commit 0643fac into main Mar 25, 2022
@vivek-yadav vivek-yadav deleted the venkatesh/fix_license_expiry_message branch March 25, 2022 11:07
shanmugapriya-tr added a commit that referenced this pull request Mar 29, 2022
shanmugapriya-tr added a commit that referenced this pull request Mar 29, 2022
shanmugapriya-tr added a commit that referenced this pull request Mar 30, 2022
shanmugapriya-tr added a commit that referenced this pull request Mar 31, 2022
shanmugapriya-tr added a commit that referenced this pull request Apr 1, 2022
shanmugapriya-tr added a commit that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automate-ui Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants