-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On a freshly provisioned server, you get a notice saying that your license is about to expire. #6830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
👷 Deploy Preview for chef-automate processing.
|
Kudos, SonarCloud Quality Gate passed! |
vivekshankar1
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice not coming any more, LGTM
vivek-yadav
approved these changes
Mar 25, 2022
shanmugapriya-tr
added a commit
that referenced
this pull request
Mar 29, 2022
This reverts commit 0643fac.
shanmugapriya-tr
added a commit
that referenced
this pull request
Mar 29, 2022
This reverts commit 0643fac.
shanmugapriya-tr
added a commit
that referenced
this pull request
Mar 30, 2022
This reverts commit 0643fac.
shanmugapriya-tr
added a commit
that referenced
this pull request
Mar 31, 2022
This reverts commit 0643fac.
shanmugapriya-tr
added a commit
that referenced
this pull request
Apr 1, 2022
This reverts commit 0643fac.
shanmugapriya-tr
added a commit
that referenced
this pull request
Apr 6, 2022
This reverts commit 0643fac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automate-ui
Team: Kinetic
Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Venkatesh-rengasamy Venkatesh.Rengasamy@progress.com
🔩 Description: What code changed, and why?
On a freshly provisioned server, you get a notice saying that your license is about to expire. So we should remove the license-exp-notification message from showing on every time signin even if user's license are not expired.
⛓️ Related Resources
customer ticket - https://getchef.zendesk.com/agent/tickets/30268
👍 Definition of Done
Removed the license-exp-notification message
👟 How to Build and Test the Change
Log into chef-automate-ui,
You can see there is no notification message - ('License Update: your current license is expiring soon.' ) shown for fresh users.
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable