Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinetics 62 enable strict transport security header for all the service endpoints #6846

Conversation

atultherajput
Copy link
Member

@atultherajput atultherajput commented Mar 30, 2022

🔩 Description: What code changed, and why?

Added HSTS response headers in some services listed by customer. These services are:

Note: Fix for MinIO service is dependent on upcoming refresh of core/minio package which is planned for the current quarter (Refer to PR: chef-base-plans/minio#5 and minio/minio#12256).

Also removed HSTS from load balancer for above services due to duplicate HSTS headers.

⛓️ Related Resources

Related issue: #5698
Customer bug: https://github.com/chef/customer-bugs/issues/471

👍 Definition of Done

All above 4 services running on ports (10115, 2000, 10161, 10117) should have HSTS ie. Strict-Transport-Security response header.

👟 How to Build and Test the Change

Rebuild the required components ie. session-service, automate-gateway, automate-ui and automate-load-balancer.
Testing can be done via UI or doing curl request inside hab studio. Ex:

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
…-all-the-service-endpoints' of github.com:chef/automate into KINETICS-62-enable-strict-transport-security-header-for-all-the-service-endpoints

Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
…-all-the-service-endpoints' of github.com:chef/automate into KINETICS-62-enable-strict-transport-security-header-for-all-the-service-endpoints

Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
…-all-the-service-endpoints' of github.com:chef/automate into KINETICS-62-enable-strict-transport-security-header-for-all-the-service-endpoints

Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@netlify
Copy link

netlify bot commented Mar 30, 2022

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 64e2642
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/624d269783668a0008006934

Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@atultherajput atultherajput self-assigned this Apr 4, 2022
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
…-all-the-service-endpoints' of github.com:chef/automate into KINETICS-62-enable-strict-transport-security-header-for-all-the-service-endpoints

Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Apr 4, 2022
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
…-all-the-service-endpoints' of github.com:chef/automate into KINETICS-62-enable-strict-transport-security-header-for-all-the-service-endpoints

Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@atultherajput atultherajput changed the base branch from main to 9decPipelineFix April 5, 2022 09:45
@atultherajput atultherajput changed the base branch from 9decPipelineFix to main April 5, 2022 09:45
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@github-actions github-actions bot removed the documentation Anything related to the Automate docs. label Apr 5, 2022
@atultherajput atultherajput marked this pull request as ready for review April 5, 2022 12:50
@kalroy
Copy link
Collaborator

kalroy commented Apr 5, 2022

Update the bldr.toml to include the library you have added.

@atultherajput
Copy link
Member Author

Update the bldr.toml to include the library you have added.

Sure. I will add that and update the PR.

Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

3.3% 3.3% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@Dmaddu Dmaddu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@kalroy kalroy merged commit b56fee7 into main Apr 21, 2022
@kalroy kalroy deleted the KINETICS-62-enable-strict-transport-security-header-for-all-the-service-endpoints branch April 21, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Strict-Transport-Security Header for all the service endpoints
4 participants