Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry Coverage for identity under Settings in Automate-ui #6903

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

Venkatesh-rengasamy
Copy link
Contributor

@Venkatesh-rengasamy Venkatesh-rengasamy commented Apr 12, 2022

Signed-off-by: venkatesh-r-r Venkatesh.Rengasamy@progress.com

🔩 Description: What code changed, and why?

Telemetry Coverage for identity under Settings in Automate-ui

⛓️ Related Resources

https://chefio.atlassian.net/browse/KINETICS-53

👍 Definition of Done

Actions in identity pages are tracked using telemetry track event.

👟 How to Build and Test the Change

inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command

npm run serve:hab

Steps for preview screen:
Go To Settings -> You can see IDENTITY section -> Click on Users or Teams or API tokens -> you can search, create, edit and delete users, teams, api token -> For each actions, you can observe the telemetry track event in Network tab(inspect the element window).

API URL - https://telemetry-acceptance.chef.io/events

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Apr 12, 2022

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 3f4653d
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/625d9bd6a92554000812facc

@Venkatesh-rengasamy Venkatesh-rengasamy self-assigned this Apr 12, 2022
@Venkatesh-rengasamy Venkatesh-rengasamy added Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues telemetry automate-ui labels Apr 12, 2022
@Venkatesh-rengasamy Venkatesh-rengasamy marked this pull request as ready for review April 12, 2022 07:24
Signed-off-by: venkatesh-r-r <Venkatesh.Rengasamy@progress.com>
Signed-off-by: venkatesh-r-r <Venkatesh.Rengasamy@progress.com>
@Venkatesh-rengasamy Venkatesh-rengasamy force-pushed the venkatesh/KINETICS-53_identity_telemetry branch from a290294 to 3f4653d Compare April 18, 2022 17:11
@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 7dc3674 into main Apr 21, 2022
@kalroy kalroy deleted the venkatesh/KINETICS-53_identity_telemetry branch April 21, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automate-ui Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants