Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry coverage for Node management in Settings tab #6917

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

Venkatesh-rengasamy
Copy link
Contributor

@Venkatesh-rengasamy Venkatesh-rengasamy commented Apr 17, 2022

Signed-off-by: venkatesh-r-r Venkatesh.Rengasamy@progress.com

πŸ”© Description: What code changed, and why?

Telemetry coverage for node management under Settings tab in Automate-ui.

⛓️ Related Resources

https://chefio.atlassian.net/browse/KINETICS-77

πŸ‘ Definition of Done

Actions in node management pages are tracked using telemetry track event.

πŸ‘Ÿ How to Build and Test the Change

inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command

npm run serve:hab

Steps for preview screen:
Go To Settings -> You can see Node Management section -> Click on Node Integrations or Credentials -> you can search, create, edit & delete both node Integrations & Credentials -> For each actions, you can observe the telemetry track event in Network tab(inspect the element window).

API URL - https://telemetry-acceptance.chef.io/events

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Signed-off-by: venkatesh-r-r <Venkatesh.Rengasamy@progress.com>
@netlify
Copy link

netlify bot commented Apr 17, 2022

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 6b74d25
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/625c43bde3f5750008bc65c7

@Venkatesh-rengasamy Venkatesh-rengasamy self-assigned this Apr 17, 2022
@Venkatesh-rengasamy Venkatesh-rengasamy added Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues telemetry labels Apr 17, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 17, 2022

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 096438d into main Apr 21, 2022
@kalroy kalroy deleted the venkatesh/KINETICS-77_node_management_telemetry branch April 21, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automate-ui Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants