Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating and Uploading airgap bundle #6973

Merged
merged 13 commits into from
May 17, 2022
Merged

Creating and Uploading airgap bundle #6973

merged 13 commits into from
May 17, 2022

Conversation

Sahiba31
Copy link
Contributor

@Sahiba31 Sahiba31 commented Apr 27, 2022

Signed-off-by: Sahiba Goyal sgoyal@progress.com

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

@netlify
Copy link

netlify bot commented Apr 27, 2022

βœ… Deploy Preview for chef-automate ready!

Name Link
πŸ”¨ Latest commit 6d97b44
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/626fef437c0067000860948d
😎 Deploy Preview https://deploy-preview-6973--chef-automate.netlify.app/automate/airgapped_installation
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Sahiba31 Sahiba31 requested a review from kalroy April 27, 2022 13:11
Sahiba31 and others added 7 commits May 2, 2022 02:28
Signed-off-by: Sahiba Goyal <sgoyal@progress.com>
Signed-off-by: Sahiba Goyal <sgoyal@progress.com>
Signed-off-by: Sahiba Goyal <sgoyal@progress.com>
Signed-off-by: Sahiba Goyal <sgoyal@progress.com>
Signed-off-by: Sahiba Goyal <sgoyal@progress.com>
Signed-off-by: Sahiba Goyal <sgoyal@progress.com>
Signed-off-by: Kallol Roy <karoy@progress.com>
@kalroy kalroy force-pushed the sahiba/upload-bundle-script branch from 4fa2681 to 0e7b7c2 Compare May 1, 2022 20:58
@kalroy kalroy marked this pull request as ready for review May 2, 2022 06:22
Signed-off-by: Sahiba Goyal <sgoyal@progress.com>
Signed-off-by: Sahiba Goyal <sgoyal@progress.com>
Signed-off-by: Sahiba Goyal <sgoyal@progress.com>
@Sahiba31 Sahiba31 requested a review from a team as a code owner May 2, 2022 08:10
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label May 2, 2022
Sahiba31 and others added 2 commits May 2, 2022 16:02
Signed-off-by: Sahiba Goyal <sgoyal@progress.com>
Signed-off-by: Kallol Roy <karoy@progress.com>
@kalroy kalroy requested a review from Dmaddu May 2, 2022 11:03
Copy link
Collaborator

@kalroy kalroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are fine. @dishanktiwari2501 needs to have a look at the documentation.

Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Dmaddu Dmaddu merged commit ab6e096 into main May 17, 2022
@Dmaddu Dmaddu deleted the sahiba/upload-bundle-script branch May 17, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants