Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

large compliance report #7074

Merged
merged 69 commits into from
Jun 21, 2022
Merged

large compliance report #7074

merged 69 commits into from
Jun 21, 2022

Conversation

iamazzeez
Copy link
Contributor

@iamazzeez iamazzeez commented May 25, 2022 •
edited
Loading

Signed-off-by: Abdul-Az aazeez@progress.com
https://chefio.atlassian.net/browse/KINETICS-128

🔩 Description: What code changed, and why?

Removed report-manager-minio-gatewaty dependency from other services like automate-deployment and report-manager-minio

⛓️ Related Resources

👍 Definition of Done

All services are working fine.

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@iamazzeez iamazzeez added the Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues label May 25, 2022
@iamazzeez iamazzeez requested review from kalroy and Dmaddu May 25, 2022 06:36
@iamazzeez iamazzeez self-assigned this May 25, 2022
@Dmaddu Dmaddu force-pushed the abdul/lcr branch 2 times, most recently from 37e1eab to b8fe9ab Compare May 30, 2022 06:17
@Dmaddu Dmaddu marked this pull request as draft June 7, 2022 12:09
@Dmaddu Dmaddu changed the base branch from abdul/lcr to main June 7, 2022 12:09
@netlify
Copy link

netlify bot commented Jun 7, 2022 •
edited
Loading

✅ Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit 3e93055
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/62b1f7b114d442000809204b
😎 Deploy Preview https://deploy-preview-7074--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Dmaddu Dmaddu force-pushed the abdul/lcr_fix branch 5 times, most recently from bb1b022 to a1e9f1f Compare June 17, 2022 15:40
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Jun 21, 2022
mchengat88 and others added 6 commits June 21, 2022 22:23
@mchengat88 @Dmaddu
api for node report headers(#5669) (#5752)
65e0c11 
Signed-off-by: Mansoor <mchengat@msystechnologies.com>
@Dmaddu
Adding initial setup code for report manager service and report manag…
dd2c3e7 
…er minio gateway (#5729)

Signed-off-by: Durga Sarat Chandra Maddu <durgasaratchandra.maddu@progress.com>
@Dmaddu
fixing node header ui to support profile and control filters and addi…
5c5d64c 
…ng test cases (#5836)

Signed-off-by: Durga Sarat Chandra Maddu <durgasaratchandra.maddu@progress.com>
@Dmaddu
server side implementation for store report service for report manager (
944b72d 
#5843)

Signed-off-by: Durga Sarat Chandra Maddu <durgasaratchandra.maddu@progress.com>
@Dmaddu
Fix buf check lint for large compliance report (#5899)
096db40 
Signed-off-by: Durga Sarat Chandra Maddu <durgasaratchandra.maddu@progress.com>
@mchengat88 @Dmaddu
paginated control information api(#5673) (#5827)
413d929 
* paginated control information api(#5673)

Signed-off-by: Mansoor <mchengat@msystechnologies.com>

* paginated control information api(#5673)

Signed-off-by: Mansoor <mchengat@msystechnologies.com>

* paginated control information api(#5673)

Signed-off-by: Mansoor <mchengat@msystechnologies.com>
Sahiba31 and others added 22 commits June 21, 2022 22:23
@Sahiba31 @Dmaddu
UI-notifications for LCR (#7081)
c0313a7 
* UI-notifications for LCR

Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>

* UI notifications for LCR

Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>

* UI notifications for LCR

Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
@Dmaddu
resolving merge conflicts
31673db 
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@Dmaddu
fixing report order
d8a5a61 
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@Dmaddu
pipeline fixes
d4e94a8 
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@Dmaddu
security pipeline fixes
f87b2d7 
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@Dmaddu
fixing security pipeline
287c892 
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@kalroy @Dmaddu
Soft fail automate-ui
ef9dee4 
Signed-off-by: Kallol Roy <kallol.roy@progress.com>
@kalroy @Dmaddu
Trying to fix unit tests
8d83eac 
Signed-off-by: Kallol Roy <kallol.roy@progress.com>
@kalroy @Dmaddu
Trying to fix build
a228058 
Signed-off-by: Kallol Roy <kallol.roy@progress.com>
@kalroy @Dmaddu
Trying to fix build with different changes
2a8e7c3 
Signed-off-by: Kallol Roy <kallol.roy@progress.com>
@kalroy @Dmaddu
Removing report manager from products.meta
0c50cd3 
Signed-off-by: Kallol Roy <kallol.roy@progress.com>
@Dmaddu
making minio root password as secret (#7159)
7c39345 
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@Sahiba31 @Dmaddu
Fixing UI Pipeline Issue (#7147)
7a43f55 
* Fixing UI Pipeline Issue

Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>

* Fixing UI Pipeline

Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>

* Fixing UI Pipeline

Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>

* Fixing UI Pipeline

Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>

* ui test fix

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

Co-authored-by: dmaddu <durgasaratchandra.maddu@progress.com>
@Dmaddu
reverting soft_fail for automate-ui
d8b3e8a 
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@Dmaddu
Fix BuildKite - [codegen] A2 protobufs (#6434)
8a5e4dc 
Signed-off-by: Durga Sarat Chandra Maddu <durgasaratchandra.maddu@progress.com>
@iamazzeez @Dmaddu
succewsfully removed dependency of minio-gateway
8b24fee 
Signed-off-by: Abdul-Az <aazeez@progress.com>
@iamazzeez @Dmaddu
rebase conflict resolved
1659fb2 
Signed-off-by: Abdul-Az <aazeez@progress.com>
@Dmaddu
fixing bldr.toml
252b87a 
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@Dmaddu
fixing bldr.toml
5c17b55 
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@Dmaddu
changes to generate habitat package
87e4012 
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@Dmaddu
adding integration test for LCR ingestion
c8df3e5 
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@kalroy @Dmaddu @dishanktiwari2501
Lcr docs (#7163)
3e93055 
* some dummy changes

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Initial changes for the configuration section

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* More changes for the configuration and the download report flow

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* adding more config values

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* updating the docs

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* removing gateway part

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Adding S3 support

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* Fixing S3 configuration

Signed-off-by: Kallol Roy <kallol.roy@progress.com>

* grammer changes in the lcr docs

Signed-off-by: Dishank Tiwari <dtiwari@progress.com>

* added to lcr page to the TOC

Signed-off-by: Dishank Tiwari <dtiwari@progress.com>

* fixes

Signed-off-by: Dishank Tiwari <dtiwari@progress.com>

* minor changes fixed

Signed-off-by: Dishank Tiwari <dtiwari@progress.com>

* version added

Signed-off-by: Dishank Tiwari <dtiwari@progress.com>

* updated the the node on the reports page

Signed-off-by: Dishank Tiwari <dtiwari@progress.com>

* updating the doc

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

Co-authored-by: Kallol Roy <kallol.roy@progress.com>
Co-authored-by: dmaddu <durgasaratchandra.maddu@progress.com>
Co-authored-by: Dishank Tiwari <dtiwari@progress.com>
@Dmaddu Dmaddu marked this pull request as ready for review June 21, 2022 16:55
@Dmaddu Dmaddu requested a review from a team as a code owner June 21, 2022 16:55
@Dmaddu Dmaddu changed the title successfully removed dependency of minio-gateway large compliance report Jun 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 83 Code Smells

22.7% 22.7% Coverage
15.4% 15.4% Duplication

@Dmaddu Dmaddu merged commit c34ecd7 into main Jun 21, 2022
@Dmaddu Dmaddu deleted the abdul/lcr_fix branch June 21, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dmaddu Dmaddu Dmaddu approved these changes

@kalroy kalroy Awaiting requested review from kalroy

Assignees

@iamazzeez iamazzeez

Labels
documentation Anything related to the Automate docs. Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@iamazzeez @Dmaddu @mchengat88 @Venkatesh-rengasamy @Sahiba31 @kalroy