Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added changes to fix the client run search #7076

Merged
merged 2 commits into from
May 27, 2022

Conversation

vinay033
Copy link
Collaborator

@vinay033 vinay033 commented May 25, 2022

Signed-off-by: Vinay Sharma vsharma@chef.io

πŸ”© Description: What code changed, and why?

As an Automate user when I type a node name to search for in the infra runs tab or compliance, it will return only an exact match. In the compliance tab, it's working fine but in the case of client run, it's showing a list of all the nodes.

⛓️ Related Resources

https://chefio.atlassian.net/browse/STALWART-123
https://github.com/chef/customer-bugs/issues/675

πŸ‘ Definition of Done

I have added some changes to the elastic search query to make this search consistent.

πŸ‘Ÿ How to Build and Test the Change

to test these changes, you need to add the sample data first

# to load the sample data in the client run
chef_load_nodes

# to load the sample data in compliance
chef_load_compliance_nodes

after adding the data you need to rebuild the config management service 
rebuild components/config-mgmt-service/

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Client run search

Screenshot 2022-05-24 at 7 07 38 PM

Compliance search

Screenshot 2022-05-24 at 7 09 32 PM

Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
@netlify
Copy link

netlify bot commented May 25, 2022

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 109c2df
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/628e0495fc389d000875e0de

@vinay033 vinay033 self-assigned this May 25, 2022
@vinay033 vinay033 added bug πŸ› Something isn't working Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues labels May 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2022

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kalroy kalroy merged commit b6c72c8 into main May 27, 2022
@kalroy kalroy deleted the Vinay/STALWART-123-fix-client-run branch May 27, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug πŸ› Something isn't working Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants