Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding lcr permissions for viewer and editor #7206

Merged
merged 2 commits into from
Jun 27, 2022
Merged

adding lcr permissions for viewer and editor #7206

merged 2 commits into from
Jun 27, 2022

Conversation

Dmaddu
Copy link
Collaborator

@Dmaddu Dmaddu commented Jun 24, 2022

Signed-off-by: Durga Sarat Chandra Maddu dmaddu@progress.com

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@Dmaddu Dmaddu requested a review from a team as a code owner June 24, 2022 12:07
@netlify
Copy link

netlify bot commented Jun 24, 2022

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit fef9e7b
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/62b983dc6aa0c80009c7d9d3

@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Jun 24, 2022
@Dmaddu Dmaddu requested review from iamazzeez and kalroy June 24, 2022 12:07
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2022

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Dmaddu Dmaddu merged commit 5eae5f8 into main Jun 27, 2022
@Dmaddu Dmaddu deleted the lcr_viewer_editor branch June 27, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants